HUDI-162 : File System view must be built with correct timeline actions #775
Conversation
There was a problem hiding this comment.
There is already a getCommitsAndCompactionTimeline in HoodieActiveTimeline, do we need this ?
There was a problem hiding this comment.
I need similar method in HoodieTimeline interface. I have renamed the method to getCommitsAndCompactionTimeline so that they will be overridden by HoodieDefaultTimeline and HoodieActiveTImeline.
hoodie-common/src/main/java/com/uber/hoodie/common/table/view/AbstractTableFileSystemView.java
Outdated
Show resolved
Hide resolved
vinothchandar
left a comment
vinothchandar
left a comment
There was a problem hiding this comment.
https://issues.apache.org/jira/browse/HUDI-162 Can you add more context around the issue here
hoodie-common/src/main/java/com/uber/hoodie/common/table/view/AbstractTableFileSystemView.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
is this needed? seems redundant with getTimeline()?
There was a problem hiding this comment.
This is needed to distinguish active timeline from commitsAndCompactionTimeline
hoodie-common/src/main/java/com/uber/hoodie/common/table/view/AbstractTableFileSystemView.java
Outdated
Show resolved
Hide resolved
|
@n3nash @vinothchandar : Addressed/Replied-to review comments. Unit tests and automated hoodie-demo (manually triggered) ran fine. As discussed earlier, will go ahead merging this change. @cdmikechen : I addressed the exception " java.lang.IllegalArgumentException: Can not create a Path from an empty string" as part of this PR. The pattern was found in few other places and I felt it is best handled together. |
…able recreation (apache#775) Co-authored-by: Vamsi <[email protected]> Co-authored-by: Vamsi <[email protected]>
3 participants
No description provided.