Revert "[HUDI-5575] Adding/Fixing auto generation of record keys w/ hudi (#7726)" #7747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udi (apache#7726)" This reverts commit 2fc20c1.
Contributor
|
can you add reasoning as to why we are reverting |
nsivabalan
approved these changes
Jan 25, 2023
… an ID based off of values within the record (apache#7640)" This reverts commit eacae1e.
Collaborator
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Jan 31, 2023
…udi (apache#7726)" (apache#7747) * Revert "[HUDI-5575] Adding/Fixing auto generation of record keys w/ hudi (apache#7726)" This reverts commit 2fc20c1. * Revert "[HUDI-5514] Add in support for a keyless workflow by building an ID based off of values within the record (apache#7640)" This reverts commit eacae1e.
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…udi (apache#7726)" (apache#7747) * Revert "[HUDI-5575] Adding/Fixing auto generation of record keys w/ hudi (apache#7726)" This reverts commit 2fc20c1. * Revert "[HUDI-5514] Add in support for a keyless workflow by building an ID based off of values within the record (apache#7640)" This reverts commit eacae1e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This reverts commit eacae1e and commit 2fc20c1.
Recently we added support for auto generation of record keys in #7640. We made it work with different keygens but it had an underlying assumption that tables will remain immutable, which may not always be true.
Impact
NA. Revert commit. Need to be fixed properly.
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist