[HUDI-5569] Fixing TableFileSystemView to detect early failed commits #7725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
| private final HoodieTimeline completedTimeline; | ||
|
|
||
| /** | ||
| * Timeline, based on which all getter work. |
Member
There was a problem hiding this comment.
this is copy pasted from above?
|
|
||
| public HoodieFileGroup(String partitionPath, String id, HoodieTimeline timeline) { | ||
| this(new HoodieFileGroupId(partitionPath, id), timeline); | ||
| public HoodieFileGroup(String partitionPath, String id, HoodieTimeline completedTimeline, HoodieTimeline writeTimeline) { |
Member
There was a problem hiding this comment.
hmmm. not sure I am a fan of this. but need to understand fully.
Contributor
|
#7738 I made a new pr because I don't have the permissions to edit this |
Contributor
Author
|
Closing this in favor of #7738 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
When we have some failed commits in the timeline before first successful commit, FS based listing could return data from the failed commit.
For eg, if timeline is:
c1.inflight, c2.complete,c3.complete
when we query hudi, data files from c1 is also returned. Fixing it as part of this patch.
Impact
FS based listing will not return data from failed commit.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
N/A
Contributor's checklist