[HUDI-5589] Fix Hudi config inference #7713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
approved these changes
Jan 20, 2023
Collaborator
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Jan 31, 2023
For a config defined by `ConfigProperty` with no default value set, even if the inference function is set with `.withInferFunction()` in `HoodieConfig`, the inference function is not invoked in `HoodieConfig` to generate the config value. This commit fixes the issue so that such a config can still get the inferred value without a default value set.
nsivabalan
pushed a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 22, 2023
For a config defined by `ConfigProperty` with no default value set, even if the inference function is set with `.withInferFunction()` in `HoodieConfig`, the inference function is not invoked in `HoodieConfig` to generate the config value. This commit fixes the issue so that such a config can still get the inferred value without a default value set.
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
For a config defined by `ConfigProperty` with no default value set, even if the inference function is set with `.withInferFunction()` in `HoodieConfig`, the inference function is not invoked in `HoodieConfig` to generate the config value. This commit fixes the issue so that such a config can still get the inferred value without a default value set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
For a config defined by
ConfigPropertywith no default value set, e.g.,DynamoDbBasedLockConfig.DYNAMODB_LOCK_PARTITION_KEY, even if the inference function is set with.withInferFunction()inHoodieConfig, the inference function is not invoked inHoodieConfigto generate the config value. This PR fixes the issue so that such a config can still get the inferred value without a default value set.This PR also adds tests to verify the config inference.
Impact
Correct the config inference. This fixes these two existing configs:
hoodie.write.lock.dynamodb.partition_key(DynamoDbBasedLockConfig.DYNAMODB_LOCK_PARTITION_KEY) andhoodie.write.lock.zookeeper.lock_key(HoodieLockConfig.ZK_LOCK_KEY). This also makes the proper inference forhoodie.write.concurrency.early.conflict.detection.strategyin #6133.Risk level
low
Documentation Update
N/A
Contributor's checklist