Skip to content

Conversation

@xicm
Copy link
Contributor

@xicm xicm commented Jan 16, 2023

Change Logs

The preCombine method we are using isT preCombine(T oldValue);This method returns the newer record.

For PartialUpdateAvroPayload we should return a new merged record, and this is implemented by T preCombine(T oldValue, Schema schema, Properties properties).

With this change, PartialUpdateAvroPayload will call T preCombine(T oldValue, Schema schema, Properties properties) , and other payloads still call T preCombine(T oldValue);

Impact

Describe any public API or user-facing feature change or any performance impact.
none

Risk level (write none, low medium or high below)

none

If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A valid fix, can we add a test case for it

@danny0405 danny0405 self-assigned this Jan 16, 2023
@danny0405 danny0405 added the priority:critical Production degraded; pipelines stalled label Jan 16, 2023
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@xicm
Copy link
Contributor Author

xicm commented Jan 17, 2023

A valid fix, can we add a test case for it

Done. :)

@xicm xicm requested a review from danny0405 January 17, 2023 01:36
@xicm
Copy link
Contributor Author

xicm commented Jan 31, 2023

@danny0405 The problem has been fix by #7759, we can close this pr.

@xicm xicm closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:critical Production degraded; pipelines stalled

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants