[HUDI-5540] Close write client after usage of DeleteMarker/RollbackTo…#7655
Merged
leesf merged 2 commits intoapache:masterfrom Feb 1, 2023
Merged
Conversation
…InstantTime/RunClean/RunCompactionProcedure
Contributor
Author
|
@hudi-bot run azure |
leesf
reviewed
Jan 13, 2023
| @@ -60,6 +62,9 @@ class DeleteMarkerProcedure extends BaseProcedure with ProcedureBuilder with Log | |||
| true | |||
| case Failure(e) => | |||
Contributor
There was a problem hiding this comment.
if success the client will not be closed?
Contributor
Author
There was a problem hiding this comment.
fixed and closed the write client in both success and exception scenarios
Collaborator
leesf
approved these changes
Feb 1, 2023
yihua
pushed a commit
that referenced
this pull request
Feb 2, 2023
…InstantTime/RunClean/RunCompactionProcedure (#7655)
yihua
added
priority:blocker
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…InstantTime/RunClean/RunCompactionProcedure (apache#7655)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…InstantTime/RunClean/RunCompactionProcedure
Change Logs
Close SparkRDDWriteClient after usage of DeleteMarker/RollbackToInstantTime/RunClean/RunCompactionProcedure so that the sparksql process can exit correctly
Impact
the sparksql process can exit correctly
Risk level (write none, low medium or high below)
None
Documentation Update
None
Contributor's checklist