Skip to content

Conversation

@voonhous
Copy link
Member

@voonhous voonhous commented Jan 11, 2023

Change Logs

Eagerly attempt to purge the partition metadata that has been dropped using the ALTER TABLE DROP PARTITION DDL to prevent data from being written itno filegroups that are flagged for deletion.

Issue is described in detail here: #7634

Impact

No impact

Risk level (write none, low medium or high below)

LOW

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@danny0405 danny0405 added area:sql SQL interfaces priority:critical Production degraded; pipelines stalled labels Jan 12, 2023
@voonhous voonhous force-pushed the HUDI-5529 branch 3 times, most recently from c1bfe16 to 63b4136 Compare January 12, 2023 10:49
@voonhous
Copy link
Member Author

voonhous commented Jan 13, 2023

TBH, i don't think this is a very good approach.

This is a non-atomic action, and if there are many partitions to iterate over, and the ALTER TABLE DROP DDL fails mid-way, subsequent writes might mess the table up in an unfixable manner.

Instead, i think we should re-initialise the consistent hashing meta (if required) when performing the writes.

@voonhous
Copy link
Member Author

Okay, re-did the fix with a re-create consistent hashing meta logic instead of deleting consistent hashing metadata logic.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:sql SQL interfaces priority:critical Production degraded; pipelines stalled

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants