-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-5506] StreamWriteOperatorCoordinator may not recommit with partial uncommitted write metadata event #7611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43bf14c to
cc3c0fc
Compare
leesf
reviewed
Jan 5, 2023
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java
Outdated
Show resolved
Hide resolved
leesf
reviewed
Jan 5, 2023
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java
Outdated
Show resolved
Hide resolved
…ial uncommitted write metadata event
leesf
approved these changes
Jan 6, 2023
Member
Author
|
@danny0405, @leesf, thanks for detailed review. I have removed the changes of the |
danny0405
approved these changes
Jan 6, 2023
Contributor
danny0405
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Collaborator
Contributor
|
Merging as Flink IT passed. |
XuQianJin-Stars
pushed a commit
that referenced
this pull request
Feb 11, 2023
nsivabalan
pushed a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 22, 2023
…ial uncommitted write metadata event (apache#7611)
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…ial uncommitted write metadata event (apache#7611)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractStreamWriteFunctionmay get the different pending instant for checkpoint among the subtasks because theStreamWriteOperatorCoordinatormay be committing the instant of the last completed checkpoint when AbstractStreamWriteFunction invokes snapshotState.StreamWriteOperatorCoordinatormay not recommit with partial uncommitted write metadata event when handling the last boostrap event which is empty boostrap event.Change Logs
StreamWriteOperatorCoordinator#handleBootstrapEventgets the inflight instant to initialize for recommit.Impact
StreamWriteOperatorCoordinatorrecommits the last pending instant for handling boostrap events.Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist