Skip to content

Conversation

@SteNicholas
Copy link
Member

@SteNicholas SteNicholas commented Jan 5, 2023

AbstractStreamWriteFunction may get the different pending instant for checkpoint among the subtasks because the StreamWriteOperatorCoordinator may be committing the instant of the last completed checkpoint when AbstractStreamWriteFunction invokes snapshotState. StreamWriteOperatorCoordinator may not recommit with partial uncommitted write metadata event when handling the last boostrap event which is empty boostrap event.

Change Logs

StreamWriteOperatorCoordinator#handleBootstrapEvent gets the inflight instant to initialize for recommit.

Impact

StreamWriteOperatorCoordinator recommits the last pending instant for handling boostrap events.

Risk level (write none, low medium or high below)

If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@SteNicholas SteNicholas force-pushed the HUDI-5506 branch 3 times, most recently from 43bf14c to cc3c0fc Compare January 5, 2023 09:51
@SteNicholas
Copy link
Member Author

SteNicholas commented Jan 6, 2023

@danny0405, @leesf, thanks for detailed review. I have removed the changes of the CkpMetadata and will create another pull request for the CkpMetadata. This pull request is mainly solved the recommit problem. PTAL.

Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hudi-bot
Copy link
Collaborator

hudi-bot commented Jan 6, 2023

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@leesf
Copy link
Contributor

leesf commented Jan 6, 2023

Merging as Flink IT passed.

@leesf leesf merged commit 3e49e4c into apache:master Jan 6, 2023
XuQianJin-Stars pushed a commit that referenced this pull request Feb 11, 2023
…ial uncommitted write metadata event (#7611)

(cherry picked from commit 3e49e4c)
nsivabalan pushed a commit to nsivabalan/hudi that referenced this pull request Mar 22, 2023
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants