Skip to content

[HUDI-5504]Fix concurrency conflict when asyncCompaction is enabled #7609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 2 commits into from
Jan 9, 2023
Merged

[HUDI-5504]Fix concurrency conflict when asyncCompaction is enabled #7609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be11f78
[HUDI-5504]Fix concurrency conflict when asyncCompaction is enabled
Jan 5, 2023
94a8e3b
minor fixes
Jan 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import org.apache.flink.configuration.Configuration;
import org.apache.flink.streaming.api.operators.OneInputStreamOperator;
import org.apache.flink.streaming.api.watermark.Watermark;
import org.apache.flink.streaming.runtime.streamrecord.LatencyMarker;
import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
import org.apache.flink.table.runtime.operators.TableStreamOperator;
import org.apache.flink.table.runtime.util.StreamRecordCollector;
Expand Down Expand Up @@ -102,6 +103,11 @@ public void processWatermark(Watermark mark) {
// no need to propagate the watermark
Copy link
Contributor

@danny0405 danny0405 Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary change.

}

@Override
public void processLatencyMarker(LatencyMarker latencyMarker) {
// no need to propagate the latencyMarker
Copy link
Contributor

@danny0405 danny0405 Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to throw exception.

Copy link
Contributor Author

@ThinkerLei ThinkerLei Jan 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@danny0405 danny0405 Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClusteringOperator should also be fixed.

Copy link
Contributor Author

@ThinkerLei ThinkerLei Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClusteringOperator fixed in HUDI-5515

}

@Override
public void processElement(StreamRecord<CompactionPlanEvent> record) throws Exception {
final CompactionPlanEvent event = record.getValue();
Expand Down