Skip to content

[HUDI-5484] Avoid using GenericRecord in HoodieColumnStatMetadata #7573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeykudinkin merged 7 commits into from
Jan 9, 2023
Merged

[HUDI-5484] Avoid using GenericRecord in HoodieColumnStatMetadata #7573

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bfec3be
unwrap & wrap GenericRecord
cxzl25 Dec 28, 2022
7079635
trigger test
cxzl25 Dec 29, 2022
92b8c60
add ut
cxzl25 Jan 3, 2023
1ac267b
trigger test
cxzl25 Jan 3, 2023
0f68fae
comment
cxzl25 Jan 7, 2023
dae318c
Revert "add ut"
cxzl25 Jan 7, 2023
c595966
move ut
cxzl25 Jan 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ public HoodieMetadataPayload(Option<GenericRecord> recordOpt) {
columnStatMetadata = HoodieMetadataColumnStats.newBuilder(METADATA_COLUMN_STATS_BUILDER_STUB.get())
.setFileName((String) columnStatsRecord.get(COLUMN_STATS_FIELD_FILE_NAME))
.setColumnName((String) columnStatsRecord.get(COLUMN_STATS_FIELD_COLUMN_NAME))
.setMinValue(columnStatsRecord.get(COLUMN_STATS_FIELD_MIN_VALUE))
.setMaxValue(columnStatsRecord.get(COLUMN_STATS_FIELD_MAX_VALUE))
.setMinValue(wrapStatisticValue(unwrapStatisticValueWrapper(columnStatsRecord.get(COLUMN_STATS_FIELD_MIN_VALUE))))

@alexeykudinkin alexeykudinkin Jan 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment explaining why we need to do that here

.setMaxValue(wrapStatisticValue(unwrapStatisticValueWrapper(columnStatsRecord.get(COLUMN_STATS_FIELD_MAX_VALUE))))
.setValueCount((Long) columnStatsRecord.get(COLUMN_STATS_FIELD_VALUE_COUNT))
.setNullCount((Long) columnStatsRecord.get(COLUMN_STATS_FIELD_NULL_COUNT))
.setTotalSize((Long) columnStatsRecord.get(COLUMN_STATS_FIELD_TOTAL_SIZE))
Expand Down
30 changes: 30 additions & 0 deletions hudi-common/src/test/java/org/apache/hudi/common/util/TestSerializationUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,16 @@

package org.apache.hudi.common.util;

import org.apache.hudi.avro.HoodieAvroUtils;
import org.apache.hudi.common.model.DeleteRecord;
import org.apache.hudi.common.model.HoodieColumnRangeMetadata;
import org.apache.hudi.common.model.HoodieKey;
import org.apache.hudi.common.model.HoodieRecord;
import org.apache.hudi.common.table.log.block.HoodieDeleteBlock;
import org.apache.hudi.metadata.HoodieMetadataPayload;

import org.apache.avro.generic.GenericRecord;
import org.apache.avro.generic.IndexedRecord;
import org.apache.avro.util.Utf8;
import org.junit.jupiter.api.Test;

Expand Down Expand Up @@ -80,6 +86,30 @@ public void testClassFullyQualifiedNameSerialization() throws IOException {
assertEquals(ByteBuffer.wrap(firstBytes), ByteBuffer.wrap(secondBytes));
}

@Test
public void testSerHoodieMetadataPayload() throws IOException {

@cxzl25 cxzl25 Jan 3, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

mvn test -Punit-tests -pl hudi-common -am -B -DfailIfNoTests=false -Dtest=TestSerializationUtils  -Pspark3.2

@alexeykudinkin alexeykudinkin Jan 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this test to hudi-spark module to make sure it's being run against every Spark version

String partitionPath = "2022/10/01";
String fileName = "file.parquet";
String targetColName = "c1";

HoodieColumnRangeMetadata<Comparable> columnStatsRecord =
HoodieColumnRangeMetadata.<Comparable>create(fileName, targetColName, 0, 500, 0, 100, 12345, 12345);

HoodieRecord<HoodieMetadataPayload> hoodieMetadataPayload =
HoodieMetadataPayload.createColumnStatsRecords(partitionPath, Collections.singletonList(columnStatsRecord), false)
.findFirst().get();

IndexedRecord record = hoodieMetadataPayload.getData().getInsertValue(null).get();
byte[] recordToBytes = HoodieAvroUtils.indexedRecordToBytes(record);
GenericRecord genericRecord = HoodieAvroUtils.bytesToAvro(recordToBytes, record.getSchema());

HoodieMetadataPayload genericRecordHoodieMetadataPayload = new HoodieMetadataPayload(Option.of(genericRecord));
byte[] bytes = SerializationUtils.serialize(genericRecordHoodieMetadataPayload);
HoodieMetadataPayload deserGenericRecordHoodieMetadataPayload = SerializationUtils.deserialize(bytes);

assertEquals(genericRecordHoodieMetadataPayload, deserGenericRecordHoodieMetadataPayload);
}

private <T> void verifyObject(T expectedValue) throws IOException {
byte[] serializedObject = SerializationUtils.serialize(expectedValue);
assertNotNull(serializedObject);
Expand Down