[HUDI-5414] No need to guard the table initialization by lock for Hoo… #7509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@alexeykudinkin Can you take a look at this change here, i see that |
XuQianJin-Stars
approved these changes
Dec 19, 2022
…dieFlinkWriteClient Different with other write clients, HoodieFlinkWriteClient invokes the dataset writing methods(#upsert or #insert) for each batch of new data set in the long running task. In current impl, a engine-specific hoodie table would be created before performing these actions, and before the table creation, some table bootstrapping operations are performed(such as table upgrade/downgrade, the metadata table bootstrap). These bootstrapping operations are guarded by a trasanction lock. In Flink, these bootstrapping operations can be avoided because they are all performed only once on the coordinator. The changes: - Make BaseHoodieWriteClient#doInitTable non abstract, it now only performs the bootstrapping operations - Add a default impl BaseHoodieWriteClient#initMetadataTable for metadata table bootstrap specifically - Add a new abstract method for creating engine-specific hoodie table
Contributor
Author
|
The failed test case |
danny0405
added a commit
to danny0405/hudi
that referenced
this pull request
Dec 20, 2022
…dieFlinkWriteClient (apache#7509) Different with other write clients, HoodieFlinkWriteClient invokes the dataset writing methods(#upsert or #insert) for each batch of new data set in the long running task. In current impl, a engine-specific hoodie table would be created before performing these actions, and before the table creation, some table bootstrapping operations are performed(such as table upgrade/downgrade, the metadata table bootstrap). These bootstrapping operations are guarded by a trasanction lock. In Flink, these bootstrapping operations can be avoided because they are all performed only once on the coordinator. The changes: - Make BaseHoodieWriteClient#doInitTable non abstract, it now only performs the bootstrapping operations - Add a default impl BaseHoodieWriteClient#initMetadataTable for metadata table bootstrap specifically - Add a new abstract method for creating engine-specific hoodie table (cherry picked from commit fd62a14)
4 tasks
danny0405
added a commit
that referenced
this pull request
Dec 21, 2022
…dieFlinkWriteClient (#7509) (#7522) Different with other write clients, HoodieFlinkWriteClient invokes the dataset writing methods(#upsert or #insert) for each batch of new data set in the long running task. In current impl, a engine-specific hoodie table would be created before performing these actions, and before the table creation, some table bootstrapping operations are performed(such as table upgrade/downgrade, the metadata table bootstrap). These bootstrapping operations are guarded by a trasanction lock. In Flink, these bootstrapping operations can be avoided because they are all performed only once on the coordinator. The changes: - Make BaseHoodieWriteClient#doInitTable non abstract, it now only performs the bootstrapping operations - Add a default impl BaseHoodieWriteClient#initMetadataTable for metadata table bootstrap specifically - Add a new abstract method for creating engine-specific hoodie table (cherry picked from commit fd62a14)
h1ap
pushed a commit
to h1ap/hudi
that referenced
this pull request
Jan 11, 2023
…dieFlinkWriteClient (apache#7509) Different with other write clients, HoodieFlinkWriteClient invokes the dataset writing methods(#upsert or #insert) for each batch of new data set in the long running task. In current impl, a engine-specific hoodie table would be created before performing these actions, and before the table creation, some table bootstrapping operations are performed(such as table upgrade/downgrade, the metadata table bootstrap). These bootstrapping operations are guarded by a trasanction lock. In Flink, these bootstrapping operations can be avoided because they are all performed only once on the coordinator. The changes: - Make BaseHoodieWriteClient#doInitTable non abstract, it now only performs the bootstrapping operations - Add a default impl BaseHoodieWriteClient#initMetadataTable for metadata table bootstrap specifically - Add a new abstract method for creating engine-specific hoodie table # Conflicts: # hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/HoodieFlinkTable.java # hudi-client/hudi-java-client/src/main/java/org/apache/hudi/table/HoodieJavaTable.java # hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/HoodieSparkTable.java
nsivabalan
pushed a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 22, 2023
…dieFlinkWriteClient (apache#7509) Different with other write clients, HoodieFlinkWriteClient invokes the dataset writing methods(#upsert or #insert) for each batch of new data set in the long running task. In current impl, a engine-specific hoodie table would be created before performing these actions, and before the table creation, some table bootstrapping operations are performed(such as table upgrade/downgrade, the metadata table bootstrap). These bootstrapping operations are guarded by a trasanction lock. In Flink, these bootstrapping operations can be avoided because they are all performed only once on the coordinator. The changes: - Make BaseHoodieWriteClient#doInitTable non abstract, it now only performs the bootstrapping operations - Add a default impl BaseHoodieWriteClient#initMetadataTable for metadata table bootstrap specifically - Add a new abstract method for creating engine-specific hoodie table
danny0405
added a commit
to danny0405/hudi
that referenced
this pull request
Mar 23, 2023
…dieFlinkWriteClient (apache#7509) Different with other write clients, HoodieFlinkWriteClient invokes the dataset writing methods(#upsert or #insert) for each batch of new data set in the long-running task. In current impl, an engine-specific hoodie table would be created before performing these actions, and before the table creation, some table bootstrapping operations are performed(such as table upgrade/downgrade, the metadata table bootstrap). These bootstrapping operations are guarded by a transaction lock. In Flink, these bootstrapping operations can be avoided because they are all performed only once on the coordinator. The changes: - Make BaseHoodieWriteClient#doInitTable non abstract, it now only performs the bootstrapping operations - Add a default impl BaseHoodieWriteClient#initMetadataTable for metadata table bootstrap specifically - Add a new abstract method for creating engine-specific hoodie table (cherry picked from commit fd62a14)
nsivabalan
pushed a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 23, 2023
…dieFlinkWriteClient (apache#7509) Different with other write clients, HoodieFlinkWriteClient invokes the dataset writing methods(#upsert or #insert) for each batch of new data set in the long-running task. In current impl, an engine-specific hoodie table would be created before performing these actions, and before the table creation, some table bootstrapping operations are performed(such as table upgrade/downgrade, the metadata table bootstrap). These bootstrapping operations are guarded by a transaction lock. In Flink, these bootstrapping operations can be avoided because they are all performed only once on the coordinator. The changes: - Make BaseHoodieWriteClient#doInitTable non abstract, it now only performs the bootstrapping operations - Add a default impl BaseHoodieWriteClient#initMetadataTable for metadata table bootstrap specifically - Add a new abstract method for creating engine-specific hoodie table (cherry picked from commit fd62a14)
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…dieFlinkWriteClient (apache#7509) Different with other write clients, HoodieFlinkWriteClient invokes the dataset writing methods(#upsert or #insert) for each batch of new data set in the long running task. In current impl, a engine-specific hoodie table would be created before performing these actions, and before the table creation, some table bootstrapping operations are performed(such as table upgrade/downgrade, the metadata table bootstrap). These bootstrapping operations are guarded by a trasanction lock. In Flink, these bootstrapping operations can be avoided because they are all performed only once on the coordinator. The changes: - Make BaseHoodieWriteClient#doInitTable non abstract, it now only performs the bootstrapping operations - Add a default impl BaseHoodieWriteClient#initMetadataTable for metadata table bootstrap specifically - Add a new abstract method for creating engine-specific hoodie table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dieFlinkWriteClient
Different with other write clients, HoodieFlinkWriteClient invokes the dataset writing methods(#upsert or #insert) for each batch of new data set in the long running task. In current impl, a engine-specific hoodie table would be created before performing these actions, and before the table creation, some table bootstrapping operations are performed(such as table upgrade/downgrade, the metadata table bootstrap). These bootstrapping operations are guarded by a trasanction lock.
In Flink, these bootstrapping operations can be avoided because they are all performed only once on the coordinator.
Change Logs
Impact
No impact
Risk level (write none, low medium or high below)
none
Documentation Update
N/A
Contributor's checklist