[HUDI-5413] Add record count payload to support pv/uv #7499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
Outdated
Show resolved
Hide resolved
added 2 commits
December 19, 2022 17:50
leesf
reviewed
Dec 20, 2022
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
Outdated
Show resolved
Hide resolved
leesf
reviewed
Dec 20, 2022
| * Payload clazz that is used for pv/uv. | ||
| * In order to use 'RecordCountAvroPayload', we need to add field [hoodie_record_count bigint] | ||
| * to the schema when creating the hudi table to record the result of pv/uv, field 'hoodie_record_count' | ||
| * does not need to be filled, and flink will automatically set it to "null", "null" represents 1. |
Contributor
There was a problem hiding this comment.
"null" represents 1 is a little strange, can be set to 1 explicitly?
Contributor
Author
There was a problem hiding this comment.
I've updated the comment, in fact the null is updated to 1 in #mergeOldRecord and #getInsertValue.
leesf
reviewed
Dec 20, 2022
| return Option.empty(); | ||
| } else { | ||
| try { | ||
| // Flink automatically set 'hoodie_record_count' to 'null', here updated to 1, so that the query result is 1. |
Contributor
There was a problem hiding this comment.
so this payload is only used for flink but not for spark?
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
@hechao-ustc no need to create a new PR, you would fix it in this PR.
Contributor
There was a problem hiding this comment.
so this payload is only used for flink but not for spark?
both can use.
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Add record count payload to support pv/uv.
Impact
No impact.
Risk level (write none, low medium or high below)
None
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist