[HUDI-5160] Fix data source write save as table #7448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiyan
added
priority:medium
xushiyan
commented
Dec 13, 2022
Comment on lines
+222
to
+223
| val sqlOptions = withDefaultSqlOptions(globalSqlOptions ++ | ||
| mapDataSourceWriteOptionsToSqlOptions(catalogProperties) ++ catalogProperties) |
Member
Author
There was a problem hiding this comment.
when use saveAsTable(), table is not yet created, hence no table configs will be available and catalogProperties contains hoodie.datasource.write.* configs, which should be converted to sql options, which will be later stored as table configs. In catalogProperties, existing sql options should take precedence over the corresponding hoodie.datasource.write.*.
4 tasks
YannByron
approved these changes
Dec 15, 2022
xushiyan
force-pushed
the
HUDI-5160-fix-saveastable
branch
from
eaed174 to
b79a063
Compare
xushiyan
force-pushed
the
HUDI-5160-fix-saveastable
branch
from
b79a063 to
9314399
Compare
Collaborator
nsivabalan
pushed a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 22, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
handle and convert data source write config to sql options when running data source write
saveAsTable()Impact
NA
Risk level
Low
Documentation Update
NA
Contributor's checklist