[HUDI-5350] Fix oom cause compaction event lost problem #7408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Dec 9, 2022
| ExceptionUtils.rethrowIfFatalErrorOrOOM(t); | ||
| final String errMsg = String.format("Executor executes action [%s] error", actionString.get()); | ||
| logger.error(errMsg, t); | ||
| if (hook != null) { |
Contributor
There was a problem hiding this comment.
Can also move the log though ~
Contributor
Author
There was a problem hiding this comment.
thanks for review, moved
danny0405
added
area:table-service
hbgstc123
force-pushed
the
oom_compact_event_lost
branch
from
53bde66 to
913d570
Compare
danny0405
changed the title
nsivabalan
pushed a commit
that referenced
this pull request
Dec 13, 2022
Co-authored-by: hbg <[email protected]>
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
Co-authored-by: hbg <[email protected]>
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
Co-authored-by: hbg <[email protected]>
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
Co-authored-by: hbg <[email protected]>
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
Co-authored-by: hbg <[email protected]>
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
Co-authored-by: hbg <[email protected]>
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
Co-authored-by: hbg <[email protected]>
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
Co-authored-by: hbg <[email protected]>
alexeykudinkin
pushed a commit
that referenced
this pull request
Dec 14, 2022
Co-authored-by: hbg <[email protected]>
Merged
4 tasks
XuQianJin-Stars
pushed a commit
that referenced
this pull request
Jan 4, 2023
Co-authored-by: hbg <[email protected]> (cherry picked from commit 115584c)
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Co-authored-by: hbg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
code from
org.apache.hudi.sink.compact.CompactOperator:In flink inline async compaction, if OOM error happen during execution of
doCompaction(...), exception hook will not be executed, and no CompactionCommitEvent is sent toCompactionCommitSink. Result in compaction instant stuck in "inflight" state, never succeed or rollback, in fact the compaction is failed.I change the execute sequence: run ExceptionHook before re-throw FatalErrorOrOOM.
I tested and it can sent
CompactionCommitEventto compaction sink to rollback the failed compaction when OOM happen during compaction.Impact
no
Risk level (write none, low medium or high below)
low
Documentation Update
no
Contributor's checklist