[HUDI-5303] Allow users to control the concurrency to submit jobs in clustering #7343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@hudi-bot run azure |
boneanxs
force-pushed
the
clustering_thread_pool
branch
2 times, most recently
from
15f8b28 to
a1538ae
Compare
4 tasks
nsivabalan
added
priority:blocker
Contributor
Author
|
@hudi-bot run azure |
Zouxxyy
reviewed
Dec 6, 2022
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java
Show resolved
Hide resolved
Contributor
|
Hi, any update on this pr? Would be great if we can land this feature! In my case, adding a thread pool could double the performance of clustering~ |
Contributor
Author
Hey @xushiyan @danny0405, could you please help to review this? |
boneanxs
force-pushed
the
clustering_thread_pool
branch
from
a1538ae to
6052ffe
Compare
danny0405
approved these changes
Jun 26, 2023
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
If there are sufficient resources in the clustering job, some clustering groups sometimes could still waits to be triggered, we use forkJoinPool to submit these jobs, and it's also difficult for clients to adjust this configure(
--conf spark.driver.extraJavaOptions=-Djava.util.concurrent.ForkJoinPool.common.parallelism), and it could also affect other tasks using the forkJoinPool, so instead, we introduce a new threadPool to control the submitting job parallelism for the clustering.Impact
Add new configure
hoodie.clustering.max.threadsto control this behavior.Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist