Skip to content

[HUDI-5283] Replace deprecated method Schema.parse With Schema.Parser. #7308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 1 commit into from
Nov 28, 2022
Merged

[HUDI-5283] Replace deprecated method Schema.parse With Schema.Parser. #7308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-common/src/main/java/org/apache/hudi/client/bootstrap/HoodieBootstrapSchemaProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public HoodieBootstrapSchemaProvider(HoodieWriteConfig writeConfig) {
public final Schema getBootstrapSchema(HoodieEngineContext context, List<Pair<String, List<HoodieFileStatus>>> partitions) {
if (writeConfig.getSchema() != null) {
// Use schema specified by user if set
Schema userSchema = Schema.parse(writeConfig.getSchema());
Schema userSchema = new Schema.Parser().parse(writeConfig.getSchema());
Copy link
Copy Markdown
Member

@codope codope Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see one more usage in AvroFileDeltaInputWriter in hudi-integ-test. Though it's not critical but would be good to fix there as well.

Copy link
Copy Markdown
Contributor

@danny0405 danny0405 Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, didn't see it, @slfan1989 , can you fire another minor PR to track this.

Copy link
Copy Markdown
Contributor Author

@slfan1989 slfan1989 Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping to review the code @codope @danny0405 , I will continue to follow up.

Copy link
Copy Markdown
Contributor Author

@slfan1989 slfan1989 Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codope I will modify it to the mock method.

if (!HoodieAvroUtils.getNullSchema().equals(userSchema)) {
return userSchema;
}
Expand Down