[MINOR] Use direct marker for spark when timeline server is disabled#7272
Merged
leesf merged 1 commit intoapache:masterfrom Nov 23, 2022
Merged
Conversation
leesf
reviewed
Nov 22, 2022
| if (writeConfig.isEmbeddedTimelineServerEnabled()) { | ||
| return MarkerType.TIMELINE_SERVER_BASED.toString(); | ||
| } else { | ||
| return MarkerType.DIRECT.toString(); |
Contributor
There was a problem hiding this comment.
The logic of turning off the timeline-server-based markers is already covered by WriteMarkersFactory.
stream2000
force-pushed
the
fix_default_marker_type_for_spark
branch
from
f0e9adc to
8f7f9ff
Compare
stream2000
force-pushed
the
fix_default_marker_type_for_spark
branch
from
8f7f9ff to
71ee4c8
Compare
Contributor
|
@hudi-bot run azure |
leesf
approved these changes
Nov 23, 2022
leesf
pushed a commit
to leesf/hudi
that referenced
this pull request
Nov 24, 2022
satishkotha
pushed a commit
to satishkotha/incubator-hudi
that referenced
this pull request
Dec 12, 2022
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Currently the default marker type for spark is timeline-server based regardless of timeline server is disabled or not. This pr change the default marker type of spark engine to direct when timeline server is disabled
Impact
Default marker type of spark engine when timeline server is diabled
Risk level (write none, low medium or high below)
none
Documentation Update
N/A
Contributor's checklist