[HUDI-5260] fix insert into sql command with strict sql insert mode and no preCombine…#7269
Merged
codope merged 3 commits intoapache:masterfrom Nov 24, 2022
Merged
Conversation
…Filed should not overwrite existing records with the same key but throw error.
kazdy
changed the title
Contributor
Author
|
@hudi-bot run azure |
kazdy
commented
Nov 22, 2022
...source/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala
Outdated
Show resolved
Hide resolved
kazdy
changed the title
codope
reviewed
Nov 23, 2022
...source/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala
Outdated
Show resolved
Hide resolved
…espective of precombine field.
Contributor
Author
|
@codope I've addressed your comment, ci is green |
Collaborator
codope
added
area:sql
codope
approved these changes
Nov 24, 2022
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
LGTM. Thanks for addressing the comments.
satishkotha
pushed a commit
to satishkotha/incubator-hudi
that referenced
this pull request
Dec 12, 2022
…pache#7269) * For COW table STRICT insert mode, PK uniqueness should be honored irrespective of precombine field.
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…pache#7269) * For COW table STRICT insert mode, PK uniqueness should be honored irrespective of precombine field.
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…pache#7269) * For COW table STRICT insert mode, PK uniqueness should be honored irrespective of precombine field.
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…pache#7269) * For COW table STRICT insert mode, PK uniqueness should be honored irrespective of precombine field.
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…pache#7269) * For COW table STRICT insert mode, PK uniqueness should be honored irrespective of precombine field.
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…pache#7269) * For COW table STRICT insert mode, PK uniqueness should be honored irrespective of precombine field.
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…pache#7269) * For COW table STRICT insert mode, PK uniqueness should be honored irrespective of precombine field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Filed should not overwrite existing records with the same key but throw error.
fixes #7266
Change Logs
When command is insert into, table has no precombine field and sql.insert.mode is set to strict then use ValidateDuplicateKeyPayload to do the insert.
Impact
No changes to public api.
Risk level (write none, low medium or high below)
low
Documentation Update
No changes to the documentation. This PR makes hudi to behave as described in the documentation.
Contributor's checklist