[HUDI-5070] Move flaky cleaner tests to separate class #7251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiyan
commented
Nov 20, 2022
| * Test Clean-By-Versions using insert/upsert API. | ||
| */ | ||
| @Test | ||
| public void testInsertAndCleanByVersions() throws Exception { |
Member
Author
There was a problem hiding this comment.
this moved to TestCleanerInsertAndCleanByVersions
xushiyan
commented
Nov 20, 2022
| * @throws Exception in case of errors | ||
| */ | ||
| @Test | ||
| public void testInsertPreppedAndCleanByVersions() throws Exception { |
Member
Author
There was a problem hiding this comment.
this moved to TestCleanerInsertAndCleanByVersions
xushiyan
commented
Nov 20, 2022
| testInsertAndCleanByVersions(SparkRDDWriteClient::insertPreppedRecords, SparkRDDWriteClient::upsertPreppedRecords, | ||
| true); | ||
| } | ||
| private void testInsertAndCleanFailedWritesByVersions( |
Member
Author
There was a problem hiding this comment.
this was moved up from the bottom to here below public void testInsertAndCleanFailedWritesByVersions()
xushiyan
commented
Nov 20, 2022
| * Test Clean-By-Versions using bulk-insert/upsert API. | ||
| */ | ||
| @Test | ||
| public void testBulkInsertAndCleanByVersions() throws Exception { |
Member
Author
There was a problem hiding this comment.
this moved to TestCleanerInsertAndCleanByVersions
xushiyan
commented
Nov 20, 2022
| * Test Clean-By-Versions using prepped versions of bulk-insert/upsert API. | ||
| */ | ||
| @Test | ||
| public void testBulkInsertPreppedAndCleanByVersions() throws Exception { |
Member
Author
There was a problem hiding this comment.
this moved to TestCleanerInsertAndCleanByVersions
xushiyan
commented
Nov 20, 2022
|
|
||
| // Keep doing some writes and clean inline. Make sure we have expected number of files remaining. | ||
| for (int i = 0; i < 8; i++) { | ||
| String newCommitTime = makeNewCommitTime(); |
Member
Author
There was a problem hiding this comment.
added try with close for client - the diff above is mostly indentation change
xushiyan
force-pushed
the
HUDI-5070-flaky-test-byversions
branch
from
5f501b7 to
a0a8d59
Compare
Collaborator
XuQianJin-Stars
approved these changes
Nov 21, 2022
satishkotha
pushed a commit
to satishkotha/incubator-hudi
that referenced
this pull request
Dec 12, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
SparkClientFunctionalTestHarnessto avoid hdfs which in CI env resulted inSimilar to #7034
Impact
NA
Risk level
none
Documentation Update
NA
Contributor's checklist