[HUDI-5269] Enhancing spark-sql write tests for some of the core user flows#7230
Merged
codope merged 3 commits intoapache:masterfrom Nov 29, 2022
Merged
[HUDI-5269] Enhancing spark-sql write tests for some of the core user flows#7230codope merged 3 commits intoapache:masterfrom
codope merged 3 commits intoapache:masterfrom
Conversation
a396524 to
b52fb73
Compare
nsivabalan
requested changes
Nov 18, 2022
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSql.scala
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSql.scala
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSql.scala
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSql.scala
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSql.scala
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSql.scala
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSql.scala
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSql.scala
Outdated
Show resolved
Hide resolved
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestDataGenerator.java
Outdated
Show resolved
Hide resolved
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestDataGenerator.java
Outdated
Show resolved
Hide resolved
Contributor
|
Please create a jira and fill in PR description. |
36b9c85 to
0d789c5
Compare
nsivabalan
approved these changes
Nov 22, 2022
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSql.scala
Outdated
Show resolved
Hide resolved
nsivabalan
approved these changes
Nov 23, 2022
satishkotha
pushed a commit
that referenced
this pull request
Dec 13, 2022
… flows (#7230) Add good test coverage for some of the core user flows w/ spark data source writes.
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
… flows (apache#7230) Add good test coverage for some of the core user flows w/ spark data source writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
We realized we don't have good test coverage for some of the core user flows w/ spark data source writes. So, enhancing the tests to cover the scenarios.
Tests coverage added w/ spark-data source writes:
This pr is modeled after #7179
This uses a different sql schema that only has regular and struct fields because the the schema in the test above was too complicated to create in sql
Impact
Will help catch any bugs around core user flows upfront.
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist