[HUDI-5209] Fixing QueueBasedExecutor in Spark bundles (missing Disruptor as dep)
#7188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@xushiyan PTAL |
alexeykudinkin
force-pushed
the
ak/spk-bndl-fix
branch
from
b155aa8 to
9edd3b3
Compare
alexeykudinkin
changed the title
QueueBasedExecutor in Spark bundles (missing Disruptor as dep)
4 tasks
Collaborator
xushiyan
reviewed
Nov 14, 2022
| <include>org.antlr:stringtemplate</include> | ||
| <include>org.apache.parquet:parquet-avro</include> | ||
|
|
||
| <include>com.lmax:disruptor</include> |
Member
There was a problem hiding this comment.
don't we want to shade this lib? it's purely internal right?
Contributor
Author
There was a problem hiding this comment.
I don't think we need to shade it, it's unlikely other engines will be using it
Member
There was a problem hiding this comment.
let me add an open question in bundle standards, where we need to put out some guideline for shading
| <include>org.antlr:stringtemplate</include> | ||
| <include>org.apache.parquet:parquet-avro</include> | ||
|
|
||
| <include>com.lmax:disruptor</include> |
alexeykudinkin
changed the title
QueueBasedExecutor in Spark bundles (missing Disruptor as dep)QueueBasedExecutor in Spark bundles (missing Disruptor as dep)
xushiyan
approved these changes
Nov 16, 2022
nsivabalan
reviewed
Nov 16, 2022
Contributor
Author
|
@nsivabalan it's not supported for either of them currently (only wired in |
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
In #5416, we added new
DisruptorExecutorrelying on LMAX Disruptor in lieu ofBoundedInMemoryQueuefor queueing records.However following things were missed during review:
QueueBasedExecutorFactoryintoHoodieMergeHelper(as well as others)This PR rectifies these issues.
Impact
Low
Risk level (write none, low medium or high below)
Low
Documentation Update
N/A
Contributor's checklist