Skip to content

[MINOR] Refactor the code for CkpMetadata #7166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 1 commit into from
Nov 9, 2022
Merged

[MINOR] Refactor the code for CkpMetadata #7166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ public class CkpMetadata implements Serializable {

private static final Logger LOG = LoggerFactory.getLogger(CkpMetadata.class);

protected static final int MAX_RETAIN_CKP_NUM = 3;
// 1 is actually enough for fetching the latest pending instant,
// keep 3 instants here for purpose of debugging.
private static final int MAX_RETAIN_CKP_NUM = 3;
Copy link
Member

@SteNicholas SteNicholas Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the max retain checkpoint number be configurable?

Copy link
Contributor Author

@danny0405 danny0405 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not add user options for internal functionalities.


// the ckp metadata directory
private static final String CKP_META = "ckp_meta";
Expand Down Expand Up @@ -106,15 +108,20 @@ public void startInstant(String instant) {
} catch (IOException e) {
throw new HoodieException("Exception while adding checkpoint start metadata for instant: " + instant, e);
}
// cache the instant
cache(instant);
// cleaning
clean(instant);
clean();
}

private void clean(String newInstant) {
private void cache(String newInstant) {
if (this.instantCache == null) {
this.instantCache = new ArrayList<>();
}
this.instantCache.add(newInstant);
}

private void clean() {
if (instantCache.size() > MAX_RETAIN_CKP_NUM) {
final String instant = instantCache.get(0);
boolean[] error = new boolean[1];
Expand Down