Skip to content

[HUDI-5003] Fix the type of InLineFileSystem`startOffset to long #6916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xushiyan merged 2 commits into from
Oct 17, 2022
Merged

[HUDI-5003] Fix the type of InLineFileSystem`startOffset to long #6916

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f12dc84
[HUDI-5003] Fix the type of InLineFileSystem`startOffset to long
wulei0302 Oct 11, 2022
ee346e2
[HUDI-5003] add InLineFSUtils`s UT
wulei0302 Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions hudi-common/src/main/java/org/apache/hudi/common/fs/inline/InLineFSUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,11 @@ public static Path getOuterFilePathFromInlinePath(Path inlineFSPath) {
* input: "inlinefs://file1/s3a/?start_offset=20&length=40".
* output: 20
*/
public static int startOffset(Path inlineFSPath) {
public static long startOffset(Path inlineFSPath) {
assertInlineFSPath(inlineFSPath);

String[] slices = inlineFSPath.toString().split("[?&=]");
return Integer.parseInt(slices[slices.length - 3]);
return Long.parseLong(slices[slices.length - 3]);
}

/**
Expand All @@ -108,11 +108,11 @@ public static int startOffset(Path inlineFSPath) {
* input: "inlinefs:/file1/s3a/?start_offset=20&length=40".
* output: 40
*/
public static int length(Path inlinePath) {
public static long length(Path inlinePath) {
assertInlineFSPath(inlinePath);

String[] slices = inlinePath.toString().split("[?&=]");
return Integer.parseInt(slices[slices.length - 1]);
return Long.parseLong(slices[slices.length - 1]);
}

private static void assertInlineFSPath(Path inlinePath) {
Expand Down
6 changes: 3 additions & 3 deletions hudi-common/src/main/java/org/apache/hudi/common/fs/inline/InLineFsDataInputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@
*/
public class InLineFsDataInputStream extends FSDataInputStream {

private final int startOffset;
private final long startOffset;
private final FSDataInputStream outerStream;
private final int length;
private final long length;

public InLineFsDataInputStream(int startOffset, FSDataInputStream outerStream, int length) throws IOException {
public InLineFsDataInputStream(long startOffset, FSDataInputStream outerStream, long length) throws IOException {
super(outerStream.getWrappedStream());
this.startOffset = startOffset;
this.outerStream = outerStream;
Expand Down