Skip to content

[HUDI-4148] Add client for hudi table service manager #6732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xushiyan merged 10 commits into from
Jan 17, 2023
Merged

[HUDI-4148] Add client for hudi table service manager #6732

xushiyan merged 10 commits into from
Jan 17, 2023

Conversation

@yuzhaojing
Copy link
Contributor

@yuzhaojing yuzhaojing commented Sep 21, 2022 •
edited
Loading

Change Logs

Refactor the part of BaseHoodieWriteClient about table service and wrapped it into BaseHoodieTableServiceClient.

About the Public API for the table service part of BaseHoodieWriteClient.

Add BaseTableServiceClient.

Impact

Affect core writer paths

Risk level

Medium

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@yuzhaojing yuzhaojing requested a review from xushiyan September 21, 2022 02:58
@danny0405 danny0405 changed the title [HUDI-4148] Preparations and client for hudi table management service [HUDI-4148] Add client for hudi table management service Sep 21, 2022
@xushiyan xushiyan mentioned this pull request Sep 21, 2022
Closed
5 tasks
@yuzhaojing
Copy link
Contributor Author

yuzhaojing commented Sep 22, 2022

@hudi-bot run azure

@yihua yihua added priority:blocker Production down; release blocker big-needle-movers area:table-service Table services labels Sep 24, 2022
@xushiyan xushiyan self-assigned this Oct 3, 2022
@xushiyan xushiyan mentioned this pull request Oct 3, 2022
Open
xushiyan
xushiyan requested changes Oct 3, 2022
View reviewed changes
@xushiyan
Copy link
Member

xushiyan commented Oct 3, 2022

@yuzhaojing please also fill up the PR description properly. as discussed, a class diagram to show the new hierarchy expedites the review.

@yuzhaojing yuzhaojing force-pushed the HUDI-4148 branch 2 times, most recently from 175998d to 011023c Compare October 14, 2022 02:50
@yuzhaojing
Copy link
Contributor Author

yuzhaojing commented Oct 14, 2022

@yuzhaojing please also fill up the PR description properly. as discussed, a class diagram to show the new hierarchy expedites the review.

Thanks for the reminder, the corresponding content has been added to the PR.

@yuzhaojing
Copy link
Contributor Author

yuzhaojing commented Oct 31, 2022

@hudi-bot run azure

1 similar comment
@yuzhaojing
Copy link
Contributor Author

yuzhaojing commented Nov 7, 2022

@hudi-bot run azure

@yuzhaojing yuzhaojing closed this Nov 7, 2022
@yuzhaojing yuzhaojing reopened this Nov 7, 2022
@yuzhaojing yuzhaojing force-pushed the HUDI-4148 branch 4 times, most recently from 36e2915 to 27ae850 Compare November 11, 2022 09:08
xushiyan
xushiyan reviewed Dec 5, 2022
View reviewed changes
@yuzhaojing yuzhaojing force-pushed the HUDI-4148 branch 2 times, most recently from 24f7f28 to 0978285 Compare December 23, 2022 14:44
@apache apache deleted a comment from hudi-bot Dec 26, 2022
@apache apache deleted a comment from hudi-bot Jan 6, 2023
@apache apache deleted a comment from hudi-bot Jan 6, 2023
@apache apache deleted a comment from yuzhaojing Jan 6, 2023
@yuzhaojing yuzhaojing closed this Jan 7, 2023
@yuzhaojing yuzhaojing reopened this Jan 7, 2023
@apache apache deleted a comment from hudi-bot Jan 8, 2023
@yuzhaojing
Copy link
Contributor Author

yuzhaojing commented Jan 9, 2023

@hudi-bot run azure

@apache apache deleted a comment from hudi-bot Jan 16, 2023
@hudi-bot
Copy link
Collaborator

hudi-bot commented Jan 16, 2023

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@xushiyan
Copy link
Member

xushiyan commented Jan 17, 2023

the CI timeout issue happens on master and is unrelated to this PR itself. will land this first. CI issue will be addressed separately

@xushiyan xushiyan merged commit c9bc03e into apache:master Jan 17, 2023
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Jan 31, 2023
@yuzhaojing @xushiyan
[HUDI-4148] Add client for Hudi table service manager (TSM) (apache#6732
38f5dbf 
)

Also refactor `Hoodie*Client` classes to separate table service APIs from write ones.

Co-authored-by: Raymond Xu <[email protected]>
@yihua yihua mentioned this pull request Mar 18, 2023
Merged
4 tasks
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
@yuzhaojing @xushiyan
[HUDI-4148] Add client for Hudi table service manager (TSM) (apache#6732
b10c082 
)

Also refactor `Hoodie*Client` classes to separate table service APIs from write ones.

Co-authored-by: Raymond Xu <[email protected]>
@Zouxxyy Zouxxyy mentioned this pull request Jul 22, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xushiyan xushiyan xushiyan approved these changes

@prasannarajaperumal prasannarajaperumal Awaiting requested review from prasannarajaperumal

@yihua yihua Awaiting requested review from yihua

Assignees

@xushiyan xushiyan

Labels

area:table-service Table services big-needle-movers priority:blocker Production down; release blocker

Projects

Hudi PR Support
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yuzhaojing @xushiyan @hudi-bot @yihua