Skip to content

[HUDI-4806] Use Avro version from the root pom for Flink bundle #6628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yihua merged 1 commit into from
Sep 12, 2022
Merged

[HUDI-4806] Use Avro version from the root pom for Flink bundle #6628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packaging/hudi-flink-bundle/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,8 +501,7 @@
<dependency>
<groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId>
<!-- Override the version to be same with Flink avro -->
<version>1.10.0</version>
<version>${avro.version}</version>
Copy link
Contributor

@danny0405 danny0405 Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that there are no compatibility issues in flink side.

Copy link
Contributor Author

@CTTY CTTY Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we've tested with Flink streamer loading data from Kafka datasource in Hudi format. And it works fine

Copy link
Contributor

@yihua yihua Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@hackergin hackergin Sep 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we've tested with Flink streamer loading data from Kafka datasource in Hudi format. And it works fine

Hi, @CTTY I met a java.lang.ClassNotFoundException when using the latest master code. Class org.apache.avro.LogicalTypes$LocalTimestampMillis seems to only appear in avro 1.10 version. Please help to confirm this problem, correct me if I am wrong .

Caused by: java.lang.ClassNotFoundException: org.apache.hudi.org.apache.avro.LogicalTypes$LocalTimestampMillis
        at java.net.URLClassLoader.findClass(URLClassLoader.java:382) ~[?:1.8.0_202]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_202]
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349) ~[?:1.8.0_202]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_202]
        at org.apache.hudi.table.HoodieTableFactory.inferAvroSchema(HoodieTableFactory.java:346) ~[hudi-flink1.14-bundle-0.13.0-SNAPSHOT.jar:0.13.0-SNAPSHOT]

Copy link
Contributor Author

@CTTY CTTY Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can revert this avro version change to unblock yourself for now

Copy link
Contributor

@danny0405 danny0405 Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fire a fix here?

<scope>compile</scope>
</dependency>

Expand Down