Skip to content

[HUDI-4739] Wrong value returned when key's length equals 1 #6539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 2 commits into from
Sep 5, 2022
Merged

[HUDI-4739] Wrong value returned when key's length equals 1 #6539

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
822e071
extracts key fields
Aug 26, 2022
0e648e2
add test
Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,21 +73,16 @@ public static String getPartitionPathFromGenericRecord(GenericRecord genericReco
*/
public static String[] extractRecordKeys(String recordKey) {
String[] fieldKV = recordKey.split(",");
if (fieldKV.length == 1) {
return fieldKV;
} else {
// a complex key
return Arrays.stream(fieldKV).map(kv -> {
final String[] kvArray = kv.split(":");
if (kvArray[1].equals(NULL_RECORDKEY_PLACEHOLDER)) {
return null;
} else if (kvArray[1].equals(EMPTY_RECORDKEY_PLACEHOLDER)) {
return "";
} else {
return kvArray[1];
}
}).toArray(String[]::new);
}
return Arrays.stream(fieldKV).map(kv -> {
final String[] kvArray = kv.split(":");
if (kvArray[1].equals(NULL_RECORDKEY_PLACEHOLDER)) {
return null;
} else if (kvArray[1].equals(EMPTY_RECORDKEY_PLACEHOLDER)) {
return "";
} else {
return kvArray[1];
}
}).toArray(String[]::new);
Comment on lines +76 to +85
Copy link
Contributor

@yihua yihua Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wuwenchi could you add a unit test for the util method considering the fixed case?

Copy link
Contributor Author

@wuwenchi wuwenchi Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

@danny0405 danny0405 Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we generate a key like name:val, can we avoid that ?

Copy link
Contributor Author

@wuwenchi wuwenchi Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a delete record is obtained, only recordKey is recorded in avro, and the fixed format of recordKey is key:value.

Copy link
Contributor

@danny0405 danny0405 Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate a little more for the details, a delete record still has a primary key right ?

Copy link
Contributor Author

@wuwenchi wuwenchi Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what I know so far. If it is delete type data, hudi will use DeleteRecord#create to generate DeleteRecord according to the data. This class records the HoodieKey and then writes it to the avro log file. When the log is read, data of type HoodieAvroRecord is generated, and the getRecordKey method is called to obtain the primary key information of the data.

Copy link
Contributor

@danny0405 danny0405 Sep 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, generally we should not use Complex key generators for single field primary key, but the fix makes the logic more robust,

}

public static String getRecordKey(GenericRecord record, List<String> recordKeyFields, boolean consistentLogicalTimestampEnabled) {
Expand Down