[minor]The Kryo of Hudi conflicts with the Kryo of Flink #6522
Conversation
|
|
| Kryo.DefaultInstantiatorStrategy instantiatorStrategy = new Kryo.DefaultInstantiatorStrategy(); | ||
| instantiatorStrategy.setFallbackInstantiatorStrategy(new StdInstantiatorStrategy()); | ||
| kryo.setInstantiatorStrategy(instantiatorStrategy); | ||
| // Handle cases where we may have an odd classloader setup like with libjars |
There was a problem hiding this comment.
We already add some shade pattern for the kryo in hudi-flink-bundle jar in #4251, does that solve your conflicts here ?
There was a problem hiding this comment.
yes，now we use hudi-flink，and the hudi only needs to modify the code and does not need to use the bundle jar
There was a problem hiding this comment.
yes，now we use hudi-flink，and the hudi only needs to modify the code and does not need to use the bundle jar
@cuibo01 can you clarify the situation please? do you mean hudi flink bundle jar will have kryo lib conflicts? we have shaded kryo for every module
Line 450 in b2a84ee
can you point out in your environment which dependency brings in kryo that caused conflicts?
yihua
added
dependencies
|
@cuibo01 @danny0405 do you still plan to land this? |
Let's not land this until we clarify what exactly caused the conflict. #6522 (comment) |
codope
added
priority:high
|
@danny0405 do you know if this is still an issue on master and in the recent Hudi releases? |
|
I didn't see any reports about it in recent releases. |
Got it. Closing this stale PR now. |
7 participants
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level: none | low | medium | high
Choose one. If medium or high, explain what verification was done to mitigate the risks.
Contributor's checklist