Skip to content

[MINOR] Improve flink dummySink's parallelism #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 1 commit into from
Aug 8, 2022
Merged

[MINOR] Improve flink dummySink's parallelism #6325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,9 @@ public static DataStreamSink<Object> clean(Configuration conf, DataStream<Object
}

public static DataStreamSink<Object> dummySink(DataStream<Object> dataStream) {
return dataStream.addSink(Pipelines.DummySink.INSTANCE).name("dummy");
return dataStream.addSink(Pipelines.DummySink.INSTANCE)
.setParallelism(1)
.name("dummy");
Copy link
Contributor

@danny0405 danny0405 Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, curious about why the append write function has rebalance exchange with this sink, and why they are not chained together.

Copy link
Collaborator

@cshuo cshuo Sep 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to jump in...But I think it's more properly to set the parallelism of dummy sink as FlinkOptions.WRITE_TASKS, so that dummy sink can be chained with hoodie_write_task, which would reduce resource cost in some cases, e.g., when slot-sharing is disabled.

}

public static String opIdentifier(String operatorN, Configuration conf) {
Expand Down