Skip to content

[HUDI-4533] Fix RunCleanProcedure's ArrayIndexOutOfBoundsException #6293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XuQianJin-Stars merged 2 commits into from
Aug 4, 2022
Merged

[HUDI-4533] Fix RunCleanProcedure's ArrayIndexOutOfBoundsException #6293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a363320
[HUDI-4533] Fix RunCleanProcedure's ArrayIndexOutOfBoundsException
Aug 3, 2022
72fd17f
[HUDI-4533] Fix RunCleanProcedure's ArrayIndexOutOfBoundsException
Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/RunCleanProcedure.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

package org.apache.spark.sql.hudi.command.procedures

import java.util.function.Supplier
import org.apache.hudi.HoodieCLIUtils
import org.apache.hudi.common.table.timeline.HoodieActiveTimeline
import org.apache.hudi.common.util.JsonUtils
Expand All @@ -26,6 +25,8 @@ import org.apache.spark.internal.Logging
import org.apache.spark.sql.Row
import org.apache.spark.sql.types.{DataTypes, Metadata, StructField, StructType}

import java.util.function.Supplier

class RunCleanProcedure extends BaseProcedure with ProcedureBuilder with Logging {

private val PARAMETERS = Array[ProcedureParameter](
Expand Down Expand Up @@ -76,7 +77,7 @@ class RunCleanProcedure extends BaseProcedure with ProcedureBuilder with Logging
val client = HoodieCLIUtils.createHoodieClientFromPath(sparkSession, basePath, props)
val hoodieCleanMeta = client.clean(cleanInstantTime, scheduleInLine, skipLocking)

if (hoodieCleanMeta == null) Seq(Row.empty)
if (hoodieCleanMeta == null) Seq.empty
else Seq(Row(hoodieCleanMeta.getStartCleanTime,
hoodieCleanMeta.getTimeTakenInMillis,
hoodieCleanMeta.getTotalFilesDeleted,
Expand Down
4 changes: 4 additions & 0 deletions ...ce/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/procedure/TestCleanProcedure.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ class TestCleanProcedure extends HoodieSparkSqlTestBase {
checkAnswer(s"select id, name, price, ts from $tableName order by id") (
Seq(1, "a1", 13, 1000)
)

val result2 = spark.sql(s"call run_clean(table => '$tableName', retain_commits => 1)")
.collect()
assertResult(0)(result2.length)
}
}

Expand Down