-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-4478] Rename existing Spark/Flink modules concisely #6230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As discussed in #5943 , we should have a more concise naming pattern for Spark/Flink modules |
…#6229) Co-authored-by: Rahil Chertara <[email protected]>
Co-authored-by: Shawn Chang <[email protected]>
|
@CTTY Let's target this for the next release, not merging into master for 0.12.0. wdyt? cc @codope @xushiyan @alexeykudinkin @danny0405 |
|
@CTTY can you please summarize the changes in the description? |
|
@alexeykudinkin Do you think we still need part of the changes from this PR, given #6550? |
|
@alexeykudinkin @CTTY : can you guys align on how to make progress on this patch. as of now, have marked it as WIP label. please remove once we have alignment and its ready to be reviewed again. |
yihua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have made significant changes in Spark and Flink integration since this PR is created. Closing this one. Feel free to create a new PR on the latest master if the changes are still useful.
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.