Skip to content

Conversation

@CTTY
Copy link
Contributor

@CTTY CTTY commented Jul 27, 2022

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@CTTY
Copy link
Contributor Author

CTTY commented Jul 27, 2022

As discussed in #5943 , we should have a more concise naming pattern for Spark/Flink modules

@CTTY CTTY changed the title [HUDI-4478] Rename existing spark/flink modules with a concise name [HUDI-4478] Rename existing Spark/Flink modules concisely Jul 28, 2022
@yihua
Copy link
Contributor

yihua commented Jul 28, 2022

@CTTY Let's target this for the next release, not merging into master for 0.12.0. wdyt? cc @codope @xushiyan @alexeykudinkin @danny0405

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@alexeykudinkin
Copy link
Contributor

@CTTY can you please summarize the changes in the description?

@yihua yihua added priority:critical Production degraded; pipelines stalled engine:spark Spark integration engine:flink Flink integration labels Sep 12, 2022
@yihua
Copy link
Contributor

yihua commented Sep 12, 2022

@alexeykudinkin Do you think we still need part of the changes from this PR, given #6550?

@alexeykudinkin
Copy link
Contributor

@yihua we do, i see this PR contains actually some other changes besides just renaming the modules. We should follow-up on it after #6550 lands though (since it deduplicates many of the classes, meaning that we don't need to move these)

@nsivabalan
Copy link
Contributor

@alexeykudinkin @CTTY : can you guys align on how to make progress on this patch. as of now, have marked it as WIP label. please remove once we have alignment and its ready to be reviewed again.

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Feb 26, 2024
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have made significant changes in Spark and Flink integration since this PR is created. Closing this one. Feel free to create a new PR on the latest master if the changes are still useful.

@yihua yihua closed this Sep 7, 2024
@CTTY CTTY deleted the ctty/hudi-spark33-rename branch September 10, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine:flink Flink integration engine:spark Spark integration priority:critical Production degraded; pipelines stalled size:M PR with lines of changes in (100, 300] status:in-progress Work in progress

Projects

Status: 🚧 Needs Repro
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

8 participants