Skip to content

Conversation

@rahil-c
Copy link
Collaborator

@rahil-c rahil-c commented Jul 25, 2022

Issue Summary

  • The payload classes from hudi-common get shaded inside hudi-hadoop-mr-bundle and are used at hive runtime . Hive realtime view is unable to reference AWSDmsAvroPayload as this class is bundled in hudi-spark.

Aim of PR

  • This change is to relocate AWSDmsAvroPayload from hudi-spark to hudi-common

@rahil-c rahil-c changed the title Relocate AWSDmsAvroPayload class to hudi-common [HUDI-4471] Relocate AWSDmsAvroPayload class to hudi-common Jul 25, 2022
@rahil-c
Copy link
Collaborator Author

rahil-c commented Jul 25, 2022

cc @umehrot2 @zhedoubushishi

@zhedoubushishi zhedoubushishi self-assigned this Jul 25, 2022
@zhedoubushishi
Copy link
Contributor

zhedoubushishi commented Jul 25, 2022

LGTM. Could you add JIRA title to the commit message? Also we may also need to update some blogs:
https://cwiki.apache.org/confluence/display/HUDI/2020/01/20/Change+Capture+Using+AWS+Database+Migration+Service+and+Hudi

@zhedoubushishi zhedoubushishi added the priority:blocker Production down; release blocker label Jul 25, 2022
@rahil-c
Copy link
Collaborator Author

rahil-c commented Jul 25, 2022

yes can add that

@rahil-c rahil-c force-pushed the rahil-c/AWSDmsAvroPayload-patch branch from 74a39d8 to 6211163 Compare July 25, 2022 23:43
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@zhedoubushishi zhedoubushishi merged commit 74d7b4d into apache:master Jul 26, 2022
@xushiyan
Copy link
Member

@zhedoubushishi @rahil-c this will break user's existing config if they set to the old full class name. we should make it BWC by keeping it in the old path, mark it as deprecated, and make it extend from the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants