[HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource #6197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiyan
force-pushed
the
HUDI-4071-default-rollback-markers
branch
from
097a89e to
f688b79
Compare
xushiyan
reviewed
Jul 23, 2022
...e/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/BaseProcedure.scala
Outdated
Show resolved
Hide resolved
5 tasks
XuQianJin-Stars
approved these changes
Jul 24, 2022
Contributor
XuQianJin-Stars
left a comment
XuQianJin-Stars
left a comment
There was a problem hiding this comment.
LGTM, when CI is passed.
xushiyan
force-pushed
the
HUDI-4071-default-rollback-markers
branch
from
f688b79 to
5ce9307
Compare
Collaborator
Member
|
@XuQianJin-Stars probably some scenarios in call procedure do not support using marker (i have not dived in the failures myself). if you have time, pls help check this. It should be set for each subclass of base procedure if not supporting marker, instead of at the base level. |
5 tasks
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Segregating all the config flips in #5643 . This one matches rollback using markers config in sql and datasource.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.