Skip to content

[HUDI-4409] Improve LockManager wait logic when catch exception #6122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanghua merged 5 commits into from
Jul 18, 2022
Merged

[HUDI-4409] Improve LockManager wait logic when catch exception #6122

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a2f372c
HUDI-4409
liujinhui1994 Jul 17, 2022
c1afd2a
HUDI-4409
liujinhui1994 Jul 17, 2022
d3c896d
HUDI-4409
liujinhui1994 Jul 17, 2022
cf4238b
HUDI-4409
liujinhui1994 Jul 18, 2022
9328f44
Merge branch 'master' into HUDI-4409
liujinhui1994 Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ public void lock() {
if (retryCount >= maxRetries) {
throw new HoodieLockException("Unable to acquire lock, lock object ", e);
}
try {
Copy link
Contributor

@yanghua yanghua Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here (before try) add a blank line?

Thread.sleep(maxWaitTimeInMs);
} catch (InterruptedException ex) {
// ignore InterruptedException here
}
} finally {
retryCount++;
}
Expand Down