[DOCS] Fix link rendering error in Docker Demo and some other typos #6083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
hi @danny0405 , can you help to review this, thanks. |
yihua
approved these changes
Aug 30, 2022
website/docs/configurations.md
Outdated
|
|
||
| > #### hoodie.keep.min.commits | ||
| > Similar to hoodie.keep.max.commits, but controls the minimum number ofinstants to retain in the active timeline.<br></br> | ||
| > Similar to hoodie.keep.max.commits, but controls the minimum number of instants to retain in the active timeline.<br></br> |
Contributor
There was a problem hiding this comment.
Please refrain from changing the configurations.md directly. This is automatically generated and updated based on the Hudi config classes.
yihua
force-pushed
the
fix-link-rendering
branch
from
2b062eb to
90ac46d
Compare
Member
Author
|
Hi @yihua, I add a new commit to solve the conflict (seems not work), and there are three commits for this PR，Do I need to squash these commits? |
zhoulii
force-pushed
the
fix-link-rendering
branch
from
a10ced8 to
5c2b583
Compare
Contributor
Don't worry about it. I'll do the squash and merge so you don't have to squash the commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
fix link rendering error in Docker Demo and some other typos.
Verify this pull request
This pull request is a trivial rework without any test coverage.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.