[HUDI-4322] Deprecate partition value extractor #6040
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiyan
force-pushed
the
HUDI-4322-deprecate-partextract
branch
from
48bbfc6 to
76abccd
Compare
xushiyan
added
component:catalog-sync
xushiyan
force-pushed
the
HUDI-4322-deprecate-partextract
branch
from
76abccd to
fd5e2d6
Compare
xushiyan
force-pushed
the
HUDI-4322-deprecate-partextract
branch
from
fd5e2d6 to
15209b8
Compare
xushiyan
changed the title
xushiyan
commented
Jul 10, 2022
Comment on lines
-190
to
-197
| public <T> String getStringOrDefault(ConfigProperty<T> configProperty) { | ||
| return getStringOrDefault(configProperty, configProperty.defaultValue().toString()); | ||
| } | ||
|
|
||
| public <T> String getStringOrDefault(ConfigProperty<T> configProperty, String defaultVal) { | ||
| Option<Object> rawValue = getRawValue(configProperty); | ||
| return rawValue.map(Object::toString).orElse(defaultVal); | ||
| } |
Member
Author
There was a problem hiding this comment.
re-arranged getString*() methods to keep them close
Collaborator
prasannarajaperumal
removed
the
priority:blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users do not need to set partition value extractor for meta sync. The existing interface
PartitionValueExtractoris marked as deprecated.stack on #6073