Skip to content

[HUDI-4332] The wrong current instant may cause file deletion in AppendWriteFunction #5988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 1 commit into from
Jun 28, 2022
Merged

[HUDI-4332] The wrong current instant may cause file deletion in AppendWriteFunction #5988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions ...-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/append/AppendWriteFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,30 +106,29 @@ public BulkInsertWriterHelper getWriterHelper() {
// Utilities
// -------------------------------------------------------------------------
private void initWriterHelper() {
this.currentInstant = instantToWrite(true);
if (this.currentInstant == null) {
final String instant = instantToWrite(true);
if (instant == null) {
// in case there are empty checkpoints that has no input data
throw new HoodieException("No inflight instant when flushing data!");
}
this.writerHelper = new BulkInsertWriterHelper(this.config, this.writeClient.getHoodieTable(), this.writeClient.getConfig(),
this.currentInstant, this.taskID, getRuntimeContext().getNumberOfParallelSubtasks(), getRuntimeContext().getAttemptNumber(),
instant, this.taskID, getRuntimeContext().getNumberOfParallelSubtasks(), getRuntimeContext().getAttemptNumber(),
this.rowType);
}

private void flushData(boolean endInput) {
final List<WriteStatus> writeStatus;
final String instant;
if (this.writerHelper != null) {
writeStatus = this.writerHelper.getWriteStatuses(this.taskID);
instant = this.writerHelper.getInstantTime();
this.currentInstant = this.writerHelper.getInstantTime();
} else {
writeStatus = Collections.emptyList();
instant = instantToWrite(false);
LOG.info("No data to write in subtask [{}] for instant [{}]", taskID, instant);
this.currentInstant = instantToWrite(false);
LOG.info("No data to write in subtask [{}] for instant [{}]", taskID, this.currentInstant);
}
final WriteMetadataEvent event = WriteMetadataEvent.builder()
.taskID(taskID)
.instantTime(instant)
.instantTime(this.currentInstant)
.writeStatus(writeStatus)
.lastBatch(true)
.endInput(endInput)
Expand Down