-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-4326] add updateTableSerDeInfo for HiveSyncTool #5920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,8 @@ | |
|
|
||
| import org.apache.hadoop.hive.metastore.IMetaStoreClient; | ||
| import org.apache.hadoop.hive.metastore.api.NoSuchObjectException; | ||
| import org.apache.hadoop.hive.metastore.api.SerDeInfo; | ||
| import org.apache.hadoop.hive.metastore.api.StorageDescriptor; | ||
| import org.apache.hadoop.hive.metastore.api.Table; | ||
| import org.apache.hadoop.hive.ql.metadata.Hive; | ||
| import org.apache.log4j.LogManager; | ||
|
|
@@ -128,6 +130,41 @@ public void updateTableProperties(String tableName, Map<String, String> tablePro | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * Update the table serde properties to the table. | ||
| */ | ||
| @Override | ||
| public void updateTableSerDeInfo(String tableName, String serdeClass, Map<String, String> serdeProperties) { | ||
| if (serdeProperties == null || serdeProperties.isEmpty()) { | ||
| return; | ||
| } | ||
| try { | ||
| Table table = client.getTable(databaseName, tableName); | ||
| serdeProperties.put("serialization.format", "1"); | ||
| StorageDescriptor storageDescriptor = table.getSd(); | ||
| SerDeInfo serdeInfo = storageDescriptor.getSerdeInfo(); | ||
| if (serdeInfo != null && serdeInfo.getParametersSize() == serdeProperties.size()) { | ||
| Map<String, String> parameters = serdeInfo.getParameters(); | ||
| boolean same = true; | ||
| for (String key : serdeProperties.keySet()) { | ||
| if (!parameters.containsKey(key) | !parameters.get(key).equals(serdeProperties.get(key))) { | ||
| same = false; | ||
| break; | ||
| } | ||
| } | ||
| if (same) { | ||
| LOG.debug("Table " + tableName + " serdeProperties already up to date, skip update"); | ||
| return; | ||
| } | ||
| } | ||
| storageDescriptor.setSerdeInfo(new SerDeInfo(null, serdeClass, serdeProperties)); | ||
| client.alter_table(databaseName, tableName, table); | ||
| } catch (Exception e) { | ||
| throw new HoodieHiveSyncException("Failed to update table serde info for table: " | ||
| + tableName, e); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void updateTableSchema(String tableName, MessageType newSchema) { | ||
| ddlExecutor.updateTableDefinition(tableName, newSchema); | ||
|
|
@@ -316,4 +353,11 @@ public void updateTableComments(String tableName, List<FieldSchema> fromMetastor | |
| } | ||
| } | ||
|
|
||
| Table getTable(String tableName) { | ||
| try { | ||
| return client.getTable(databaseName, tableName); | ||
| } catch (TException e) { | ||
| throw new HoodieHiveSyncException(String.format("Database: %s, Table: %s does not exist", databaseName, tableName), e); | ||
| } | ||
| } | ||
|
Comment on lines
+356
to
+362
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. where do we use this method? other methods from this class just call client.getTable(). we should not introduce random helpers that lowers the code quality |
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need to pass serde class from the API. it's controlled by the base file format, which is taken from the sync config.