Skip to content

[HUDI-4251] fix problems about the command 'commits sync' description does not match. #5881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yihua merged 1 commit into from
Jun 20, 2022
Merged

[HUDI-4251] fix problems about the command 'commits sync' description does not match. #5881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hudi-cli/src/main/java/org/apache/hudi/cli/commands/CommitsCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,8 @@ public String compareCommits(@CliOption(key = {"path"}, help = "Path of the tabl
}
}

@CliCommand(value = "commits sync", help = "Compare commits with another Hoodie table")
public String syncCommits(@CliOption(key = {"path"}, help = "Path of the table to compare to") final String path) {
@CliCommand(value = "commits sync", help = "Sync commits with another Hoodie table")
public String syncCommits(@CliOption(key = {"path"}, help = "Path of the table to sync to") final String path) {
Copy link
Contributor

@yihua yihua Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this CLI command does not have the actual implementation. Still good to fix the docs due to copy and paste.

Copy link
Contributor Author

@Forus0322 Forus0322 Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just came into learnning hudi, I don’t know a lot

HoodieCLI.syncTableMetadata = HoodieTableMetaClient.builder().setConf(HoodieCLI.conf).setBasePath(path).build();
HoodieCLI.state = HoodieCLI.CLIState.SYNC;
return "Load sync state between " + HoodieCLI.getTableMetaClient().getTableConfig().getTableName() + " and "
Expand Down