Skip to content

[HUDI-4187] Fix partition order in aws glue sync #5731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xushiyan merged 4 commits into from
Jun 4, 2022
Merged

[HUDI-4187] Fix partition order in aws glue sync #5731

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ffde1c
Fix partition order aws glue sync
parisni Jun 1, 2022
5ac3728
formatting
parisni Jun 2, 2022
60bca8c
Indentation
parisni Jun 2, 2022
f8324f2
identation again
parisni Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,19 +271,22 @@ public void createTable(String tableName,
try {
Map<String, String> mapSchema = parquetSchemaToMapSchema(storageSchema, syncConfig.supportTimestamp, false);

List<Column> schemaPartitionKeys = new ArrayList<>();
List<Column> schemaWithoutPartitionKeys = new ArrayList<>();
for (String key : mapSchema.keySet()) {
String keyType = getPartitionKeyType(mapSchema, key);
Column column = new Column().withName(key).withType(keyType.toLowerCase()).withComment("");
// In Glue, the full schema should exclude the partition keys
if (syncConfig.partitionFields.contains(key)) {
schemaPartitionKeys.add(column);
} else {
if (!syncConfig.partitionFields.contains(key)) {
schemaWithoutPartitionKeys.add(column);
}
}

// now create the schema partition
List<Column> schemaPartitionKeys = syncConfig.partitionFields.stream().map(partitionKey -> {
String keyType = getPartitionKeyType(mapSchema, partitionKey);
return new Column().withName(partitionKey).withType(keyType.toLowerCase()).withComment("");
}).collect(Collectors.toList());

StorageDescriptor storageDescriptor = new StorageDescriptor();
serdeProperties.put("serialization.format", "1");
storageDescriptor
Expand Down