Skip to content

[HUDI-3994] - Added support for initializing DeltaStreamer without a … #5630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codope merged 1 commit into from
Sep 13, 2022
Merged

[HUDI-3994] - Added support for initializing DeltaStreamer without a … #5630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,24 @@ private static SparkConf buildSparkConf(String appName, String defaultMaster, Ma
return SparkRDDWriteClient.registerClasses(sparkConf);
}

private static SparkConf buildSparkConf(String appName, Map<String, String> additionalConfigs) {
final SparkConf sparkConf = new SparkConf().setAppName(appName);
sparkConf.set("spark.ui.port", "8090");
sparkConf.setIfMissing("spark.driver.maxResultSize", "2g");
sparkConf.set("spark.serializer", "org.apache.spark.serializer.KryoSerializer");
sparkConf.set("spark.hadoop.mapred.output.compress", "true");
sparkConf.set("spark.hadoop.mapred.output.compression.codec", "true");
sparkConf.set("spark.hadoop.mapred.output.compression.codec", "org.apache.hadoop.io.compress.GzipCodec");
sparkConf.set("spark.hadoop.mapred.output.compression.type", "BLOCK");
Comment on lines +290 to +296
Copy link
Contributor

@yihua yihua Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neuw84 are these particularly for AWS Glue? Could we also update the Hudi website / docs on how Deltastreamer can be used on serverless platform?

Copy link
Contributor Author

@Neuw84 Neuw84 Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yihua,

I just copied them from the other constructor. Most of them won´t have effect on Glue as the change of internal configs is very restricted.

Will try to make that happen, I was thinking on posting on the AWS blog but it will good to post this also on Hudi website/docs.

Will work on the Hudi website next.

Thanks for your inputs!


additionalConfigs.forEach(sparkConf::set);
return SparkRDDWriteClient.registerClasses(sparkConf);
}

public static JavaSparkContext buildSparkContext(String appName, Map<String, String> configs) {
return new JavaSparkContext(buildSparkConf(appName, configs));
}

public static JavaSparkContext buildSparkContext(String appName, String defaultMaster, Map<String, String> configs) {
return new JavaSparkContext(buildSparkConf(appName, defaultMaster, configs));
}
Expand Down
15 changes: 10 additions & 5 deletions ...-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,10 @@ public static class Config implements Serializable {
description = "the min sync interval of each sync in continuous mode")
public Integer minSyncIntervalSeconds = 0;

@Parameter(names = {"--spark-master"}, description = "spark master to use.")
public String sparkMaster = "local[2]";
@Parameter(names = {"--spark-master"},
description = "spark master to use, if not defined inherits from your environment taking into "
+ "account Spark Configuration priority rules (e.g. not using spark-submit command).")
public String sparkMaster = "";

@Parameter(names = {"--commit-on-errors"}, description = "Commit even when some records failed to be written")
public Boolean commitOnErrors = false;
Expand Down Expand Up @@ -553,9 +555,12 @@ public static final Config getConfig(String[] args) {
public static void main(String[] args) throws Exception {
final Config cfg = getConfig(args);
Map<String, String> additionalSparkConfigs = SchedulerConfGenerator.getSparkSchedulingConfigs(cfg);
JavaSparkContext jssc =
UtilHelpers.buildSparkContext("delta-streamer-" + cfg.targetTableName, cfg.sparkMaster, additionalSparkConfigs);

JavaSparkContext jssc = null;
if (StringUtils.isNullOrEmpty(cfg.sparkMaster)) {
jssc = UtilHelpers.buildSparkContext("delta-streamer-" + cfg.targetTableName, additionalSparkConfigs);
} else {
jssc = UtilHelpers.buildSparkContext("delta-streamer-" + cfg.targetTableName, cfg.sparkMaster, additionalSparkConfigs);
}
if (cfg.enableHiveSync) {
LOG.warn("--enable-hive-sync will be deprecated in a future release; please use --enable-sync instead for Hive syncing");
}
Expand Down
6 changes: 4 additions & 2 deletions .../src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieMultiTableDeltaStreamer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,8 +355,10 @@ public static class Config implements Serializable {
description = "the min sync interval of each sync in continuous mode")
public Integer minSyncIntervalSeconds = 0;

@Parameter(names = {"--spark-master"}, description = "spark master to use.")
public String sparkMaster = "local[2]";
@Parameter(names = {"--spark-master"},
description = "spark master to use, if not defined inherits from your environment taking into "
+ "account Spark Configuration priority rules (e.g. not using spark-submit command).")
public String sparkMaster = "";

@Parameter(names = {"--commit-on-errors"}, description = "Commit even when some records failed to be written")
public Boolean commitOnErrors = false;
Expand Down