-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-2150] Rename/Restructure configs for better modularity #5608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@xushiyan please help review... ε(*´・∀・`)з゙ |
|
Assigned to myself. Will review before end of week. |
|
Please ping me anytime if needed @codope |
|
@liujinhui1994 can you pls rebase and resolve conflicts? also update the PR description to reflect the changes in details, rather than just repeating the jira title. This PR is about moving some clean/archive related configs to its own config classes right? |
|
@xushiyan Yes, you are right. |
|
@liujinhui1994 I'll pick up the review this week. A couple of high-level questions:
|
codope
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liujinhui1994 The changes look clean. It would be helpful for configurations page on hudi website as well.
The summary of this diff is mainly that the cleaning, archival, payload related configs have been extracted away from HoodieCompactionConfig. I did not spot any config key changes so we should be good in terms of backward compatibility in this case.
But, have we thought about users who use contants? For e.g.
df.write.format("hudi")
...
.option(HoodieCompactionConfig.AUTO_CLEAN.key, "true")
...
Won't this patch affect such users?
|
I understand your idea. In very strict cases, the user will be required to modify the specified class. I understand that the impact of this is not big. After upgrading, users need to convert HoodieCompactionConfig to HoodieCleanConfig/HoodiePayloadConfig. Or it won't matter if the user uses the following: |
|
My mistake Force push. cry. There seems to be no recovery. I redevelop some @codope |
Tips
What is the purpose of the pull request
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.