Skip to content

Conversation

@kumudkumartirupati
Copy link
Contributor

What is the purpose of the pull request

Updates the missing content of DeltaStreamer documentation of v0.11.0.

Brief change log

Verify this pull request

This pull request is for updating the documentation.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Copy link
Contributor

@pratyakshsharma pratyakshsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment.

Default: false
--sync-tool-classes
Classes (comma-separated) to be used for syncing meta. Shall be used only when --enable-sync or --enable-hive-sync is set to true
Note: When used this with deprecated --enable-hive-sync flag, HiveSyncTool will always be run along with any other classes mentioned in here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove the Note: section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the note. Please check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I meant to indicate this change -

When used this with -> When used with

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@pratyakshsharma pratyakshsharma self-assigned this May 17, 2022
@xushiyan xushiyan added the docs label May 22, 2022
Copy link
Member

@xushiyan xushiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep the current version of docs also updated?

@kumudkumartirupati
Copy link
Contributor Author

@xushiyan I have updated the docs for 0.10.0 and 0.10.1 as well for the --enable-sync flag if this is what you meant. Please check and let me know.

@kumudkumartirupati
Copy link
Contributor Author

Also, @xushiyan --sync-tool-classes is not supposed to be present in 0.11.0. I have removed it there and will re-add it once #5597 is finalized and the release version is known.

@xushiyan
Copy link
Member

@xushiyan I have updated the docs for 0.10.0 and 0.10.1 as well for the --enable-sync flag if this is what you meant. Please check and let me know.

@kumudkumartirupati i actually meant the "current" version, which is in sync with master version. The versioned docs are snapshotted for each release. You can read more from the README under asf-site branch to understand the versioning.

Once you land #5597 you can come back here and update according to the latest development.

@kumudkumartirupati
Copy link
Contributor Author

@xushiyan I have updated the docs for 0.10.0 and 0.10.1 as well for the --enable-sync flag if this is what you meant. Please check and let me know.

@kumudkumartirupati i actually meant the "current" version, which is in sync with master version. The versioned docs are snapshotted for each release. You can read more from the README under asf-site branch to understand the versioning.

Once you land #5597 you can come back here and update according to the latest development.

Thanks for the pointers @xushiyan . I have done the necessary changes. I will update if any, post #5597 is landed.

@xushiyan xushiyan added the status:triaged Issue has been reviewed and categorized label May 30, 2022
@xushiyan xushiyan merged commit fa3c92f into apache:asf-site May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:triaged Issue has been reviewed and categorized

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants