Skip to content

Conversation

@uday08bce
Copy link
Contributor

Tips

What is the purpose of the pull request

To fix the RAT plugin issue identified in the issue HUDI-3890

Brief change log

  • Removed <exclude>**/*.sql</exclude> from parent pom.xml so that RAT plugin can scan the .sql file
  • Added the license in .sql file (hudi\hudi-spark-datasource\hudi-spark\src\test\resources\sql-statements.sql)

Verify this pull request

  • This pull request can be verified by existing tests
  • We can also run mvn apache-rat:check to validate the licenses

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@uday08bce uday08bce changed the title fix rat plugin issue [HUDI-3890]fix rat plugin issue May 16, 2022
@apache apache deleted a comment from hudi-bot May 16, 2022
@yanghua yanghua changed the title [HUDI-3890]fix rat plugin issue [HUDI-3890] Fix rat plugin issue May 17, 2022
@yanghua
Copy link
Contributor

yanghua commented May 17, 2022

@hudi-bot run azure

@yanghua
Copy link
Contributor

yanghua commented May 18, 2022

@uday08bce Would you please rebase this PR to see if the flaky test has been fixed?

@uday08bce
Copy link
Contributor Author

@yanghua thanks for the comment , Updated the PR after rebase

@yanghua
Copy link
Contributor

yanghua commented May 18, 2022

@yanghua thanks for the comment , Updated the PR after rebase

The way you have rebased may be wrong. Would you please use git pull --rebase upstream master?

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@uday08bce
Copy link
Contributor Author

Created another PR : #5644 so closing it

@uday08bce uday08bce closed this May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants