-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-3994] - Added support for initializing DeltaStreamer without a defined Spark Master #5463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Master. That will enable the usage of DeltaStreamer on environments such as AWS Glue or other serverless environments where the spark master is inherited and we do not have access to it.
|
@hudi-bot run azure |
|
One high level comment, will it be possible to add test cases for this change? |
|
Hi @pratyakshsharma, I could try to add a test for initialising the Spark Context. However, the change is very simple and looking for the tests I did not see any that test that tests the other constructors. The only thing is that now, if no Spark master is not defined it will inherit or the application will fail as no Spark context is defined. Previously it would run with What do you have in mind? (looking for some guidance). |
|
I am not having anything as of now. Let me check and get back to you. In the mean time, please check CI failures. |
|
Hi, Should I rebase it from latest stable version? Almost every time I merge somethings breaks ( and it´s not because my changes). Thanks! |
|
To be able to merge, you need to rebase it on master itself. |
Tips
What is the purpose of the pull request
Added support for initializing DeltaStreamer without a defined Spark Master. That will enable the usage of DeltaStreamer on environments such as AWS Glue or other serverless environments where the spark master is inherited and we do not have access to it.
Brief change log
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR