[HUDI-3963] Use Lock-Free Message Queue Disruptor Improving Hoodie Writing Efficiency #5416
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,174 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hudi.execution; | ||
|
|
||
| import static org.apache.hudi.execution.HoodieLazyInsertIterable.getTransformFunction; | ||
|
|
||
| import org.apache.avro.generic.IndexedRecord; | ||
| import org.apache.hudi.common.model.HoodieRecord; | ||
| import org.apache.hudi.common.table.timeline.HoodieActiveTimeline; | ||
| import org.apache.hudi.common.testutils.HoodieTestDataGenerator; | ||
| import org.apache.hudi.common.util.Option; | ||
| import org.apache.hudi.common.util.queue.BoundedInMemoryQueueConsumer; | ||
| import org.apache.hudi.common.util.queue.DisruptorExecutor; | ||
| import org.apache.hudi.common.util.queue.WaitStrategyFactory; | ||
| import org.apache.hudi.config.HoodieWriteConfig; | ||
| import org.apache.hudi.exception.HoodieException; | ||
| import org.apache.hudi.testutils.HoodieClientTestHarness; | ||
| import org.apache.spark.TaskContext; | ||
| import org.apache.spark.TaskContext$; | ||
| import org.junit.jupiter.api.AfterEach; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.util.List; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.Future; | ||
| import java.util.concurrent.atomic.AtomicReference; | ||
|
|
||
| import scala.Tuple2; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class TestDisruptorExecutionInSpark extends HoodieClientTestHarness { | ||
|
|
||
| private final String instantTime = HoodieActiveTimeline.createNewInstantTime(); | ||
|
|
||
| @BeforeEach | ||
| public void setUp() throws Exception { | ||
| initTestDataGenerator(); | ||
| initExecutorServiceWithFixedThreadPool(2); | ||
| } | ||
|
|
||
| @AfterEach | ||
| public void tearDown() throws Exception { | ||
| cleanupResources(); | ||
| } | ||
|
|
||
| private Runnable getPreExecuteRunnable() { | ||
| final TaskContext taskContext = TaskContext.get(); | ||
| return () -> TaskContext$.MODULE$.setTaskContext(taskContext); | ||
| } | ||
|
|
||
| @Test | ||
| public void testExecutor() { | ||
|
|
||
| final List<HoodieRecord> hoodieRecords = dataGen.generateInserts(instantTime, 128); | ||
|
|
||
| HoodieWriteConfig hoodieWriteConfig = mock(HoodieWriteConfig.class); | ||
| when(hoodieWriteConfig.getWriteBufferSize()).thenReturn(8); | ||
| BoundedInMemoryQueueConsumer<HoodieLazyInsertIterable.HoodieInsertValueGenResult<HoodieRecord>, Integer> consumer = | ||
| new BoundedInMemoryQueueConsumer<HoodieLazyInsertIterable.HoodieInsertValueGenResult<HoodieRecord>, Integer>() { | ||
|
|
||
| private int count = 0; | ||
|
|
||
| @Override | ||
| protected void consumeOneRecord(HoodieLazyInsertIterable.HoodieInsertValueGenResult<HoodieRecord> record) { | ||
| count++; | ||
alexeykudinkin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| @Override | ||
| protected void finish() { | ||
| } | ||
|
|
||
| @Override | ||
| protected Integer getResult() { | ||
| return count; | ||
| } | ||
| }; | ||
| DisruptorExecutor<HoodieRecord, Tuple2<HoodieRecord, Option<IndexedRecord>>, Integer> exec = null; | ||
|
|
||
| try { | ||
| exec = new DisruptorExecutor(hoodieWriteConfig.getWriteBufferSize(), hoodieRecords.iterator(), consumer, | ||
| getTransformFunction(HoodieTestDataGenerator.AVRO_SCHEMA), WaitStrategyFactory.DEFAULT_STRATEGY, getPreExecuteRunnable()); | ||
| int result = exec.execute(); | ||
| // It should buffer and write 100 records | ||
alexeykudinkin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| assertEquals(128, result); | ||
| // There should be no remaining records in the buffer | ||
| assertFalse(exec.isRemaining()); | ||
| } finally { | ||
| if (exec != null) { | ||
| exec.shutdownNow(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testInterruptExecutor() { | ||
| final List<HoodieRecord> hoodieRecords = dataGen.generateInserts(instantTime, 100); | ||
| ExecutorService pool = Executors.newSingleThreadExecutor(); | ||
|
|
||
| HoodieWriteConfig hoodieWriteConfig = mock(HoodieWriteConfig.class); | ||
| when(hoodieWriteConfig.getWriteBufferSize()).thenReturn(1024); | ||
| BoundedInMemoryQueueConsumer<HoodieLazyInsertIterable.HoodieInsertValueGenResult<HoodieRecord>, Integer> consumer = | ||
| new BoundedInMemoryQueueConsumer<HoodieLazyInsertIterable.HoodieInsertValueGenResult<HoodieRecord>, Integer>() { | ||
|
|
||
| @Override | ||
| protected void consumeOneRecord(HoodieLazyInsertIterable.HoodieInsertValueGenResult<HoodieRecord> record) { | ||
| try { | ||
| while (true) { | ||
| Thread.sleep(1000); | ||
|
||
| } | ||
| } catch (InterruptedException ie) { | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| protected void finish() { | ||
| } | ||
|
|
||
| @Override | ||
| protected Integer getResult() { | ||
| return 0; | ||
| } | ||
| }; | ||
|
|
||
| DisruptorExecutor<HoodieRecord, Tuple2<HoodieRecord, Option<IndexedRecord>>, Integer> executor = null; | ||
| AtomicReference<Exception> actualException = new AtomicReference<>(); | ||
| try { | ||
| executor = new DisruptorExecutor(hoodieWriteConfig.getWriteBufferSize(), hoodieRecords.iterator(), consumer, | ||
| getTransformFunction(HoodieTestDataGenerator.AVRO_SCHEMA), WaitStrategyFactory.DEFAULT_STRATEGY, getPreExecuteRunnable()); | ||
| DisruptorExecutor<HoodieRecord, Tuple2<HoodieRecord, Option<IndexedRecord>>, Integer> finalExecutor = executor; | ||
|
||
|
|
||
| Future<?> future = pool.submit(() -> { | ||
| try { | ||
| finalExecutor.execute(); | ||
| } catch (Exception e) { | ||
| actualException.set(e); | ||
| } | ||
|
|
||
| }); | ||
| future.cancel(true); | ||
| future.get(); | ||
| assertTrue(actualException.get() instanceof HoodieException); | ||
|
||
| } catch (Exception e) { | ||
| // ignore here | ||
| } finally { | ||
| if (executor != null) { | ||
| executor.shutdownNow(); | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we introduce enum for this. also, we can remove "EXECUTOR" suffix from it. for eg, in case of Key gen, enum is named as KeyGeneratorType and value is just "SIMPLE". we don't call it as "SIMPOLE_KEY_GEN" as its repetitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. Changed!