[HUDI-3951]support general parameter 'sink.parallelism' for flink-hudi#5405
Conversation
hehuiyuan
changed the title
hehuiyuan
force-pushed
the
support-sink-parallesim
branch
from
b7cdd5f to
d005971
Compare
|
@hudi-bot run azure |
|
Hi @yanghua , who can look at this pr? |
|
@XuQianJin-Stars when merging the PR, can you please make sure JIRA id is added to the message title? for easy referencing. thanks! |
| // ------------------------------------------------------------------------ | ||
| public static final ConfigOption<Integer> SINK_PARALLELISM = FactoryUtil.SINK_PARALLELISM; | ||
|
|
||
| public static final ConfigOption<String> TABLE_NAME = ConfigOptions |
There was a problem hiding this comment.
Hello, it seems that we want to add a default parallelism to the sink, but there is already parallelism param named write.tasks, can we rename this param to write.default_tasks or something ? And we should add test in TestHoodieTableFactory, before we make agreement, can you revert this PR first ? Thanks ~
There was a problem hiding this comment.
Hello, it seems that we want to add a default parallelism to the sink, but there is already parallelism param named
write.tasks, can we rename this param towrite.default_tasksor something ? And we should add test inTestHoodieTableFactory, before we make agreement, can you revert this PR first ? Thanks ~
well, let me revert this PR first, Then come to an agreement, sorry @hehuiyuan my mistake.
|
https://issues.apache.org/jira/browse/HUDI-3951 @hehuiyuan add this message to What is the purpose of the pull request and jira's Template. |
…link-hudi (apache#5405)" This reverts commit bda3db0.
6 participants
What is the purpose of the pull request
support generan parameter 'sink.parallelism' for flink-hudi