Skip to content

Comments

[HUDI-3876] Fixing fetching partitions in GlueSyncClient#5318

Merged
xushiyan merged 1 commit intoapache:masterfrom
nsivabalan:glueSyncNextTokenFix
Apr 14, 2022
Merged

[HUDI-3876] Fixing fetching partitions in GlueSyncClient#5318
xushiyan merged 1 commit intoapache:masterfrom
nsivabalan:glueSyncNextTokenFix

Conversation

@nsivabalan
Copy link
Contributor

What is the purpose of the pull request

  • Fetching partitions from glue sync may not complete in one call. if a token is set in the result, we have to make another request.

Brief change log

  • Fixed GlueSyncClient to make repeated getPartitions() call if not fully fetched.

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@nsivabalan nsivabalan force-pushed the glueSyncNextTokenFix branch from e5f1732 to bb6dda9 Compare April 13, 2022 18:44
@nsivabalan nsivabalan added the priority:blocker Production down; release blocker label Apr 13, 2022
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@xushiyan xushiyan merged commit a081c2b into apache:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants