Skip to content

Comments

[HUDI-3847] Fix NPE due to null schema in HoodieMetadataTableValidator#5284

Merged
yihua merged 1 commit intoapache:masterfrom
yihua:HUDI-3847-fix-npe-schema-read
Apr 11, 2022
Merged

[HUDI-3847] Fix NPE due to null schema in HoodieMetadataTableValidator#5284
yihua merged 1 commit intoapache:masterfrom
yihua:HUDI-3847-fix-npe-schema-read

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Apr 10, 2022

What is the purpose of the pull request

This PR fixes the NullPointerException during reading Hudi log files in HoodieMetadataTableValidator, possibly due to empty or partial log files written by an inflight instant.

Brief change log

  • Adds the logic to skip the check of a log file if the schema cannot be read or IOException happens.

Verify this pull request

This pull request is tested using a long-running HoodieMetadataTableValidator job to make sure that NPE is not thrown when empty or partial log files are present.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit 63a099c into apache:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants