[HUDI-3845] Fix delete mor table's partition with urlencode's error#5282
Merged
xushiyan merged 1 commit intoapache:masterfrom Apr 14, 2022
Merged
[HUDI-3845] Fix delete mor table's partition with urlencode's error#5282xushiyan merged 1 commit intoapache:masterfrom
xushiyan merged 1 commit intoapache:masterfrom
Conversation
xushiyan
reviewed
Apr 10, 2022
| int bufferSize) throws IOException { | ||
| FSDataInputStream fsDataInputStream = fs.open(logFile.getPath(), bufferSize); | ||
| String escapePathName = PartitionPathEncodeUtils.unescapePathName(logFile.getPath().toString()); | ||
| FSDataInputStream fsDataInputStream = fs.open(new Path(escapePathName), bufferSize); |
Member
There was a problem hiding this comment.
this has performance impact; the unescape is looking at every char, also calling logFile.getPath() construct a Path object and then L474 constructs another Path, which is costly. There should be a deeper fix to this: we shouldn't have to unescape every logFile.getPath() to read.
5 tasks
XuQianJin-Stars
force-pushed
the
HUDI-3845
branch
from
85b49cc to
e329fa9
Compare
xiarixiaoyao
approved these changes
Apr 14, 2022
xushiyan
approved these changes
Apr 14, 2022
xushiyan
pushed a commit
that referenced
this pull request
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.