[HUDI-3807] Add a new config to control the use of metadata index in HoodieBloomIndex #5268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
reviewed
Apr 9, 2022
| JavaRDD<List<HoodieKeyLookupResult>> keyLookupResultRDD; | ||
| if (config.isMetadataBloomFilterIndexEnabled()) { | ||
| if (config.getBloomIndexUseMetadata() | ||
| && getCompletedMetadataPartitions(hoodieTable.getMetaClient().getTableConfig()) |
Contributor
There was a problem hiding this comment.
can we add an api to tableConfig only getCompletedMetadataPartitions(). we can compute once and return the same rather than parsing the table config entry again and again.
Contributor
Author
There was a problem hiding this comment.
HoodieTableMetadataUtil::getCompletedMetadataPartitions is an existing API. We can tackle this code cleanup in a separate PR: HUDI-3836.
yihua
force-pushed
the
HUDI-3807-config-read-multi-modal-index
branch
from
201bac7 to
230df29
Compare
Collaborator
nsivabalan
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This PR adds a new config to control the use and reading of metadata index in HoodieBloomIndex, separate from the existing write configs, e.g.,
hoodie.metadata.index.column.stats.enable, which control the writing of the index in metadata table.Brief change log
hoodie.bloom.index.use.metadatato control the use of index from metadata table in HoodieBloomIndex. When true, the index lookup uses bloom filters and column stats from metadata table when available to speed up the process.Verify this pull request
This pull request is already covered by existing tests.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.